search

umbraco / Umbraco.Commerce.Issues

18 stars 2 forks source link

Sorting product attribute values is collapsing columns #244

Closed bjarnef closed 3 years ago

bjarnef commented 3 years ago

Not actually a bug, but more a minor enhancement of the UI. When sorting product attribute values it seems the "columns" are collapsed.

It is a known "issue" using ui-sortable when using tables, e.g. previous in prevalues for Nested Content in Umbraco core. https://github.com/umbraco/Umbraco-CMS/pull/4832

I think a similar "helper" can be used to solve this :)

image

I would another example from Umbraco core here: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.controller.js#L85-L95

Additional context Vendr v1.5.0-rc0074

mattbrailsford commented 3 years ago

Fixed and will be in the 1.5.0 RC

bjarnef commented 3 years ago

@mattbrailsford should this one be closed now? 😁

MichaelNielsenDK commented 3 years ago

This issue is duplicate to this https://github.com/vendrhub/vendr/issues/236

bjarnef commented 3 years ago

@MichaelNielsenDK although this issue also is about the sorting, it is a different issue. The "columns" are collapsed while dragging the table row. It has been fixed in latest RC builds. The fix can be seen here in the demo store: https://github.com/vendrhub/vendr-demo-store/commit/3abd6908096c823a1d249b099657fc23dbcc4814#diff-8bdba80138809c9b105be363be02d4db3cb80b45db33ccca05931a77a756365aR6031-R6040