umbraco / Umbraco.Commerce.Issues

18 stars 2 forks source link

Update Newtonsoft.Json dependency #451

Closed skttl closed 7 months ago

skttl commented 10 months ago

Describe the bug When building, I get a warning that UmbracoCommerce (12.1.3) is depending on Newtonsoft.Json 13.0.0 but since version 13.0.0 has been removed from Nuget, it can't find it, and resolves to 13.0.1 instead.

Would be nice, if the dependency in Commerce could be >= 13.0.1 && < 14.0.0 instead.

mattbrailsford commented 7 months ago

This will be fixed in 10.0.7 and 12.1.6. Doesn't look like it's needed for v13 as that already has a greater dependency.

seanrockster commented 2 months ago

I'm getting this issue. I'm trying to upgrade my umbraco v12 to v13 and it wont let me upgrade commerce from 12.1.5

Umbraco.Commerce.Core 12.1.5 depends on Newtonsoft.Json (>= 13.0.0 && < 14.0.0) but Newtonsoft.Json 13.0.0 was not found. An approximate best match of Newtonsoft.Json 13.0.1 was resolved.