umbraco / Umbraco.Commerce.Issues

17 stars 2 forks source link

Since version 13.1.0 orderline properties aren't displayed in order details page #494

Closed stefanie27 closed 7 months ago

stefanie27 commented 7 months ago

Describe the bug We have orderline properties we want to display per orderline item and used https://docs.umbraco.com/umbraco-commerce/key-concepts/ui-config-files to configure that. I tested it locally and can pin point the issue to version 13.1.0. In version 13.0.2 the data is displayed correctly.

Expected behavior Orderline property information should be displayed as before the upgrade

Screenshots Display in version 13.0.2 https://www.screencast.com/t/1O5dCQANQ3 Display in version 13.1.0 https://www.screencast.com/t/gCytefGwa

Umbraco Commerce version: Issue was introduces in version 13.1.0 and is also present in version 13.1.2

mattbrailsford commented 7 months ago

Could you show me your UI config file?

stefanie27 commented 7 months ago

Hi @mattbrailsford,

Please see attached.

bestRestaurants.order.editor.config.json

mattbrailsford commented 7 months ago

Excellent. I’ll dig in and see what’s going on 👍🏻

mattbrailsford commented 7 months ago

Hey @stefanie27

What operating system are you running on? And can you confirm the items in your additionalInfo section are working correctly?

Also, can you try renaming your file to all lowercase and reformatting your file into valid JSON. All the keys should be wrapped in quotes and we'll need to remove the commented out items.

{
  "orderLine": {
      "properties": [
          { "alias": "cardnumber", "label": "GIVEX card number", "isReadOnly": false },
          { "alias": "cardstatus", "label": "GIVEX status", "isReadOnly": false },
          { "alias": "certificatenumber", "label": "Certificate number", "isReadOnly": false },
          { "alias": "certificatestatus", "label": "Certificate status", "isReadOnly": false },
          { "alias": "certificateexpiry", "label": "Certificate expiry", "isReadOnly": false },
          { "alias": "recipientEmail", "label": "Recipient email", "isReadOnly": false },
          { "alias": "recipientName", "label": "Recipient name", "isReadOnly": true },
          { "alias": "senderName", "label": "Sender name", "isReadOnly": true },
          { "alias": "message", "label": "Message", "isReadOnly": true },
          { "alias": "cardDesign", "label": "Card design", "isReadOnly": true }
      ]
  },
  "customer": {
      "company": { "alias": "company", "label": "Company Name" },
      "taxCode": { "alias": "taxCode", "label": "Tax Code" },
      "telephone": { "alias": "telephone", "label": "Telephone" }
  },
  "billing": {
      "addressLine1": { "alias": "billingAddressLine1", "label": "Street Address Line 1" },
      "addressLine2": { "alias": "billingAddressLine2", "label": "Street Address Line 2" },
      "city": { "alias": "billingCity", "label": "City" },
      "zipCode": { "alias": "billingZipCode", "label": "Zip Code" },
      "telephone": { "alias": "billingTelephone", "label": "Telephone" }
  },
  "shipping": {
      "sameAsBilling": { "alias": "shippingSameAsBilling", "label": "Same as billing", "trueValue": "1", "falseValue": "0" },
      "firstName": { "alias": "shippingFirstName", "label": "First Name" },
      "lastName": { "alias": "shippingLastName", "label": "Last Name" },
      "addressLine1": { "alias": "shippingAddressLine1", "label": "Street Address Line 1" },
      "addressLine2": { "alias": "shippingAddressLine2", "label": "Street Address Line 2" },
      "city": { "alias": "shippingCity", "label": "City" },
      "zipCode": { "alias": "shippingZipCode", "label": "Zip Code" },
      "telephone": { "alias": "shippingTelephone", "label": "Telephone" }
  },
  "notes": {
      "customerNotes": { "alias": "comments", "label": "Customer Comments" },
      "internalNotes": { "alias": "notes", "label": "Internal Notes" }
  },
  "additionalInfo": [
    {
      "alias": "ipAddress",
      "label": "IP Address",
      "isReadOnly": true
    },
    {
      "alias": "forterAction",
      "label": "Forter Decision",
      "isReadOnly": true
    },
    {
      "alias": "forterMessage",
      "label": "Forter Message",
      "isReadOnly": true
    },
    {
      "alias": "StarshipItOrderID",
      "label": "StarshipIt Order ID",
      "isReadOnly": true
    },
    {
      "alias": "StarshipItError",
      "label": "StarshipIt Error",
      "isReadOnly": true
    }
  ],
  "view": "/App_Plugins/UmbracoCommerce/backoffice/views/order/subviews/edit_custom.html"
}
stefanie27 commented 7 months ago

Hi @mattbrailsford,

Additional information is displayed correctly - same as before. Just orderline properties aren't displayed. I tested renaming the file to all lower case and also copied the JSON valid version you provided above. All without any success.

I assume it must be an issue with orderline properties, since all the other information is displayed as before.

OS on our DEV server is Windows 10

mattbrailsford commented 7 months ago

Ahhh, I think I've just spotted it.

I noticed that you didn't have any showInOrderLineSummary properties set to true, and when I checked our docs it should indeed default to true. But when I recently made these models strongly typed, I didn't ensure this was true by default.

stefanie27 commented 7 months ago

Hi @mattbrailsford, after adding that attribute the information displayed again. Thanks for clarifying. Will you make the default value true again in next release?

mattbrailsford commented 7 months ago

I will indeed.

Glad to hear this resolves it. Hopefully once I’ve found a solution to your other issue I can get an update out.

Thank you for testing and validating the issue 👍🏻

mattbrailsford commented 7 months ago

v13.1.3 with this fix in has been released