umbraco / Umbraco.Deploy.Issues

1 stars 0 forks source link

Conditionals on Forms do not transfer #158

Closed RasmusUmbraco closed 1 year ago

RasmusUmbraco commented 1 year ago

When transferring a Form with conditionals these are not sent to the target environment.

Reproduction:

  1. Add a condition to a Form on the source environment image
  2. Transfer the Form to the target environment
  3. The Form is missing the condition on the target environment image

Tested on Cloud on these versions: image It has also been reported on-premise on v11.

AndyButland commented 1 year ago

Looks to be an issue since Deploy 4 (for Umbraco 8). This "page condition" was introduced in Forms in 8.9, which is later than the Deploy dependency in that version. We need to update the artifact creation and mapping to handle this additional field.

beingonlinedave commented 1 year ago

Hi, to add to this, I encountered an issue with conditions on workflow items.

Steps to reproduce issue:

Create a form, add a Send email with template (Razor) workflow item and add a condition to it e.g. that it only runs if a value from a dropdown field is equal to a certain value. Then try and transfer that to another environment and see if the conditions are present in the other environment. In my experience it actually removed the conditions from the other environment, as I had manually added them based on it not working originally.

In this scenario, it is quite a problem as in my case I have about 10 different different emails that are set to go to different client support email address depending on the choices from dropdowns on the form. When it is transferred and all the conditions are not there, it sends an email to everyone of them meaning the customer will probably get 10 people getting in touch with them.

Hope this helps.

AndyButland commented 1 year ago

Thanks for the additional information @beingonlinedave - we'll make sure workflow conditions, which are another feature introduced more recently in Forms than Deploy was aware of when the transfer of form information was built, are also included in the fix for this issue.