Form condition validation issue when used in conjunction with FileUpload FieldType

[Aaen]

What did you do? Created a form with a file upload field, multiple mandatory fields and a drop-down list with conditionals that show/hide fields based on values selected. Submitted form after choosing the conditional option where the original mandatory field is hidden with no value inside that input.

What did you expect to happen? Form to submit and for record data to be stored in database + file uploaded to Umbraco media folder

What actually happened? Yellow screen occurred with error log (stack trace attached in error-log.txt)

What version of Umbraco are you using? 7.5.3

What version of Umbraco Forms or Contour are you using? 4.3.3 but the issue occurs in 4.4.0 as well

This is the old issue: https://issues.umbraco.org/issue/CON-1221

[pijemcolu]

error-log.txt

Uploaded the log file from the previous issue tracker.

[KeironM]

Hi guys

I am following up on Owain Williams request re-open this issue last week and as requested by Dennis Aaen please find some more detail into the issue affecting our client

Umbraco Version - 7.5.8

Forms Version - 4.4.7

Problem

I have a multi step umbraco form that contains a mandatory file upload (Step 2) where the user must upload a document. This field is breaking and forms are being submitted with the document missing.

Example form

http://viewpoint-staging.lewis.co.uk/work-with-us/current-vacancies/both-other/?q=Finance%20Assistant%20-%20Payroll

Scenario 1

If you click Previous Step after uploading a CV file in Step 2 it creates a yellow error screen (log details attached)

Scenario 2

Similarly you click Previous Step on Step 3 after uploading a file on Step 2 it creates a yellow error screen

Let me know if you need any more info that could help you with this.

Thanks Keiron multistep-forms-fileupload-error.txt

[warrenbuckley]

This has been merged in @clausjensen but a patch release for the 4.x version would need to be arranged. Can I leave that with you please Claus?!

[clausjensen]

@warrenbuckley @bergmania We need this cherrypicked to later version branches as well. One of you up for getting that done before we do any releases? 😃

[bergmania]

@clausjensen, I'm pretty sure I couldn't reproduce this on latest version. But I'm not aware when it has been resolved.

[clausjensen]

@bergmania just checked up on it - the fix was done in v7 already so that's why it seems to be working fin there. Could you cherrypick to v6 since we will need to do v4 and v6 releases then?

[nul800sebastiaan]

This is now all merged and ready for release tomorrow.

[nul800sebastiaan]

I've reopened this issue. During testing we found that, while the YSOD is now gone, the form validation kicks in and ask you to upload the required file, even though we're already listing that you have indeed uploaded a file.

So, steps to reproduce:

1. Fill in the form step with the required upload field
2. Click next
3. Click previous - you no longer get a YSOD
4. Click next - validation kicks in and asks you to upload a file, even though you already did

[warrenbuckley]

V7 PR is here - https://github.com/umbraco/Forms/pull/217 V6 PR is here - https://github.com/umbraco/Forms/pull/218 V4 PR is here - https://github.com/umbraco/Forms/pull/219

[umbrabot]

Hiya @Aaen,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version 8.9.0

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: