umbraco / Umbraco.Marketplace.Issues

Public issue tracker for Umbraco Marketplace
2 stars 0 forks source link

Page shows no initial content in Safari #26

Closed greystate closed 1 year ago

greystate commented 1 year ago

It just dawned on me that having to choose a category before seeing anything is not the default experience - just mine, because I'm using Safari (v16.1 on macOS Ventura 13.0.1).

Looks like this:

Screenshot 2022-12-07 at 09 52 18

Mind you, it was only after having seen the site in Firefox (while double-checking something else) that I saw this, so probably isn't a huge problem — as soon as I choose a category I get content. Also, clicking the logo to go back to the frontpage, I get the expected initial content of "Most popular" and "Recently added".

FWIW, here's the console error appearing on the initial load:

Screenshot 2022-12-07 at 09 57 27
nathanwoulfe commented 1 year ago

Hey @greystate from what I can see, this is related somehow to minification and how Safari parses the minified JS - the uninitialized variable in this case is the homepage component itself, which would obviously be causing some major issues everywhere if it weren't browser-specific.. Will try to track down the cause, but may need to find an HQer on a Mac to investigate properly.

greystate commented 1 year ago

A somewhat worse consequence of this JS-requirement: Clicking the List my package button in the footer does absolutely nothing... or maybe even worse: Even typing in the URL https://marketplace.umbraco.com/listing still just gives you an empty page.

This one doesn't throw any console errors, but maybe there's been some updates already?

Still Safari only, yes, but that includes iPhones, so...

greystate commented 1 year ago

Looks like the frontpage issue has been fixed - should I report a separate issue for the /listing page?

AndyButland commented 1 year ago

It's OK thanks @greystate - we'll pick it up from here.

greystate commented 1 year ago

Awesome @AndyButland — can confirm this has been fixed 👍 (both / and /listing)

AndyButland commented 1 year ago

Great, good to hear. Thanks for reporting back.

nathanwoulfe commented 1 year ago

In the interests of full transparency, nothing was changed explicitly related to this issue - something must have fixed it, but through no conscious effort on my part...