umbraco / Umbraco.Marketplace.Issues

Public issue tracker for Umbraco Marketplace
2 stars 0 forks source link

Sorting by `Recently updated` seems to be bugged #43

Closed abjerner closed 1 year ago

abjerner commented 1 year ago

When doing a search in the Marketplace, it's possible to do a search ordered by Recently updated. Eg. like shown here:

image

Just by looking at the first four results, the fourth one should be before the others. And packages with more recent released should have been shown before these.

I'm noticing dates seem to be formatted in Danish. Could it be that dates are sorted as strings by dd/MM/yyyy (typical format in Danish) rather than ISO 8601 yyyy-MM-dd?

image

nathanwoulfe commented 1 year ago

Hey @abjerner I can't (fully) replicate this one - I was able to mess up the paging by changing the filters after loading a second page, which did result in one or two cards out of order, but they weren't in the first row so not sure it's related to this issue (regardless, I've fixed the paging for the next release).

Sorting all happens on the server, in the EF query, so we can rule out culture-specific date formatting. The dates are displayed using the local culture, hence your seeing Danish.

We do have a published and modified date, I need to check the difference between the two, might be that we should sort on the other value.

AndyButland commented 1 year ago

I've had a look at this. We are currently using a last modified date, which does include changes other than the publishing of a new version of the package. However I think it does make sense to consider only that (otherwise minor tweaks to a listing would count as an update and bring the package back to the top of the list.

This will be the case from the next release (which I plan to do tomorrow morning).

abjerner commented 1 year ago

Awesome. Works better already 👍

Think @callumbwhyte will also appreciate this ☕ 😉