search

umbraco / Umbraco.Marketplace.Issues

Public issue tracker for Umbraco Marketplace
2 stars 0 forks source link

Footer links don't work, or make sense in the backoffice. #49

Closed JasonElkin closed 1 year ago

JasonElkin commented 1 year ago

In the Umbraco backoffice, the Marketplace experience is a little off.

The "Privacy", "Terms and Conditions" and "Report an issue" links don't work.

https://github.com/umbraco/Umbraco.Marketplace.Issues/assets/7151793/a690579c-630a-4e05-bd32-715dc19c6d76

Also, the cookie settings don't work - it doesn't seem possible to change consent from within the backoffice (there are a lot of cookie-related console errors). That said, I don't think that third-party cookies should need to be a consideration at all in the Umbraco backoffice.

AndyButland commented 1 year ago

Seems we haven't scrolled down that far! @nathanwoulfe - do you think we could simply hide these things? We have the querystring coming from the back-office IFRAME so load backoffice.css only if in the back-office, so presumably we could hide the footer links and also find a way to not prompt for the cookie confirmation?

nathanwoulfe commented 1 year ago

Yup, I agree hiding the footer links makes sense. Backoffice view should be packages and very little else, it's not intended to be a full embed of the Marketplace. I need to confirm, but have a feeling we don't track at all in the backoffice, so cookies would indeed be redundant.

Leave it with me 😄

nathanwoulfe commented 1 year ago

@JasonElkin we aim to please - this is fixed now. No more footer in the backoffice, and a slightly improved header too.

JasonElkin commented 1 year ago

Thanks muchly @nathanwoulfe and @AndyButland!