search

umbraco / Umbraco.Marketplace.Issues

Public issue tracker for Umbraco Marketplace
2 stars 0 forks source link

Package details view can't be closed using `esc` key #50

Closed bjarnef closed 1 year ago

bjarnef commented 1 year ago

When the details view is open it can be closed via the close-button in upper right corner, but not using esc key, which it should to make the site accessible.

image

nathanwoulfe commented 1 year ago

Hey @bjarnef, thanks for the heads-up - this was working previously, I must have borked it when I refactored the routing for the overlay. Will get it sorted.

nathanwoulfe commented 1 year ago

Will be fixed in our next deployment - there were some changes to component nesting which meant elements previously at the document root (and available to document.querySelectorAll) had moved into a different component and hence a different shadow DOM so were no longer queryable. Changed to use a DOM-piercing query and all is good again.