Avoid double path encoding inside Azure.Storage.Blobs

umbraco / Umbraco.StorageProviders

MIT License

29 stars 21 forks source link

Avoid double path encoding inside Azure.Storage.Blobs #51

Closed JoseMarcenaro closed 2 years ago

JoseMarcenaro commented 2 years ago

Fixes #45 by avoiding to send an URL encoded path to the Azure.Storage.Blobs provider.

ronaldbarendse commented 2 years ago

This seems to be fixed in the CMS by https://github.com/umbraco/Umbraco-CMS/pull/12132 and I can at least confirm everything is working as expected in Umbraco.Cms 10.3.0-rc and Umbraco.StorageProviders.AzureBlob 10.0.0, so I'll close this PR for that reason.

This fix also adds URL decoding to AzureBlobFileProvider, but that should only be concerned with file paths, not URL paths and might actually cause double URL decoding issues.

JoseMarcenaro commented 2 years ago

@ronaldbarendse , I can confirm it worked for me when switching to Umbraco v10.3 - no need of this PR. Thanks!