umbraco / Umbraco.UI

Umbraco UI Components
MIT License
118 stars 41 forks source link

Story for input readonly #880

Closed bjarnef closed 3 weeks ago

bjarnef commented 2 months ago

Description

Add story for readonly state of <uui-input>. I also fixed bugs of some of the other stories, which didn't render anything.

Types of changes

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

github-actions[bot] commented 2 months ago

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bjarnef commented 1 month ago

@madsrasmussen @nielslyngsoe I added a story for readonly state as well and some of the stories didn't render anything:

E.g. https://uui.umbraco.com/?path=/story/uui-input--number-input

image

bjarnef commented 1 month ago

@madsrasmussen while you work on the readonly PRs in backoffice, you can perhaps check this PR as well? https://github.com/umbraco/Umbraco.CMS.Backoffice/pulls/madsrasmussen