umbraco / Umbraco.UIBuilder.Issues

Back office UI builder for Umbraco
3 stars 2 forks source link

Save button not visible #41

Closed matt-tolliday-iss closed 2 years ago

matt-tolliday-iss commented 2 years ago

Describe the bug Since updating to 1.6.0 the "Save" button is no longer visible on any collection entity edit.

When creating a new entity the 'Save' button is also not visible.

The only option on all collections is now "Return to List"

Unsure if I have misread any of the release notes has there been an update to enable the save button? Could it a permissions thing?

None of the collections have .DisableUpdate or .DisableCreate

Just noticed this in the DOM:

image

Steps To Reproduce Steps to reproduce the behavior:

  1. Go to any collection
  2. No Save button visible

Expected behavior The Save button should be present and clickable.

Screenshots image

Environment (please complete the following information):

mattbrailsford commented 2 years ago

Hey @matt-tolliday-iss

Hmm, I can't replicate this on my install. In the last release with did add Save Action buttons that appear as a dropdown on the save button which means we swapped the save button we had before for one that supports this menu. If you looks at your screenshot it's the div that comes after the commented out piece of code so it looks like it's being rendered, but for some reason the button isn't showing.

It's not a browser caching issue is it?

matt-tolliday-iss commented 2 years ago

I've refreashed my browser cache and no luck.

I can see this with package 1.6.0:

image

looks as though there is no content rendered within it, are there any conditions around that? Or did I need to change any configuration to show it?

and this with package 1.5.2

image

mattbrailsford commented 2 years ago

My gut feeling is that it's using the old JS for some reason as the buttons are defined in the edit controller. Given the markup is rendering, and the variables it binds to weren't present in the previous version it makes me think it's using the old js file

matt-tolliday-iss commented 2 years ago

Good instincts!

Looks like is was the inbuilt Umbraco minifcation cache:

https://our.umbraco.com/documentation/Reference/Configuration/RuntimeMinificationSettings/#manually-changing-the-cache-buster-version

mattbrailsford commented 2 years ago

🎉