umbraco / Umbraco.UIBuilder.Issues

Back office UI builder for Umbraco
3 stars 2 forks source link

Saving a node does't close the editor #57

Closed marcoteodoro closed 9 months ago

marcoteodoro commented 1 year ago

Describe the bug Hi @mattbrailsford I'm using your Konstruct app with a custom repository, and that's why I'm not 100% sure if this is a bug or just me using your great package in the wrong way.

But while I was debugging that within the collectionlistview.directive there is a block of code where the editorSerice.Close is commented.


                    if ($scope.openInInfiniteEditor) {
                        editorService.open({
                            collectionAlias: item.collectionAlias,
                            id: item.id,
                            parentId: $scope.parentEntityId,
                            // virtualNodePrefix: $scope.virtualNodePrefix,
                            submit: function (model) {
                                $scope.$broadcast("konstrukt.reloadListView");
                                //editorService.close();
                            },
                            close: function () {
                                editorService.close();
                            },
                            view: "/App_Plugins/Konstrukt/backoffice/konstrukt/edit.html"
                        });
                    } else {
                        $location.path(item.editPath);
                    }
                },```

![image](https://user-images.githubusercontent.com/3866444/234931827-3cc1ff78-ee5d-4c14-b47d-6ab9ac2f5e67.png)

**Steps To Reproduce**
Steps to reproduce the behavior:
1. Edit or create a new entity
2. Click on save 
3. we receive the success but the dialog is not close

**Expected behavior**
Close the dialog once the update/insert is complete

**Screenshots**
![image](https://user-images.githubusercontent.com/3866444/234931827-3cc1ff78-ee5d-4c14-b47d-6ab9ac2f5e67.png)

**Environment (please complete the following information):**
 - Windows 10
 - Browser all
 - Umbraco Version version 10.4.2
 - Product Version1.6.4

---
_This item has been added to our backlog AB#34769_
marcoteodoro commented 1 year ago

image

acoumb commented 9 months ago

Hi @marcoteodoro ,

I have released version 12.0.2 of Umbraco.UIBuilder with a fix to this issue.

Thank you, Adrian