umbraco / Umbraco.UIBuilder.Issues

Back office UI builder for Umbraco
3 stars 2 forks source link

Make the type in GetImpl nullable in custom repos #77

Closed jemayn closed 8 months ago

jemayn commented 10 months ago

Describe the bug I am implementing a custom repo for a UI Builder collection like this:

public class MovieUiBuilderRepository : Repository<Movie, int>

protected override Movie GetImpl(int id)
{
        throw new NotImplementedException();
}

However, based on just an ID we can't guarantee that the T type (Movie in my case) exists. It would be nice to have an option to say the T type with the id doesn't exist.

Easiest way would be if it was nullable and we could just return null.


This item has been added to our backlog AB#35173

acoumb commented 8 months ago

Hi @jemayn ,

We have addressed this with the latest major release of Umbraco.UIBuilder.

Regards, Adrian