umbraco / Umbraco.UIBuilder.Issues

Back office UI builder for Umbraco
3 stars 2 forks source link

In object extensions the name property does not seem to handle expressions pointing to nested objects in 13 #97

Closed dennispedersenakqa closed 4 months ago

dennispedersenakqa commented 5 months ago

Describe the bug Every uniquerow in my ui builder list has a row connected to it by relational database, however when it comes to the view the "Row" attribute does not print anything. image image image (The "D" you see in name right now is "Lang" from the unique row. Steps To Reproduce Steps to reproduce the behavior:

  1. Create 2 tables, where one refers to the other one (one can have many of the other)
  2. Just try to load the backoffice ui builder list view and get presented with data only from the unique table

Expected behavior The list view would show 6 different fields. however it only shows the Name property

Environment (please complete the following information):

Additional context In umbraco 12 this worked as expected. And when I look at my custom repository I can see that I return a full unique row back with all properties. However it's not showing

krebil commented 5 months ago

This seems to be a problem with the property expression handling rather than the underlying relation.

In object extensions the name property does not seem to handle expressions pointing to nested objects. This worked in v12. image

acoumb commented 4 months ago

Hi @dennispedersenakqa ,

The issue has been fixed with the 13.1.2 minor release.

Thank you, Adrian

krebil commented 4 months ago

@acoumb

This is still an issue for searchable properties. It throws an exception in EntityService.FindEntities when the expression points to nested objects.

System.ArgumentException: Property 'System.String Number' is not defined for type 'Models.DTOs.PatternDTO' (Parameter 'property')

Itt looking for the number property on a model that doesn't have it. The expression looks like: .AddSearchableProperty(x => x.Row.Number)

acoumb commented 4 months ago

Hi @krebil ,

Thank you for bringing this to our attention. Currently UIBuilder does not support using nested objects as searchable in any version, but I will be looking into options for adding support to this use case.

Adrian

acoumb commented 4 months ago

Hi @krebil ,

I've added support for properties of nested objects with the latest 13.1.4 release.

Thanks, Adrian