search

umbraco / Umbraco.Workflow.Issues

Public issue tracker for Umbraco Workflow
1 stars 0 forks source link

Can't reach Umbraco installer with Umbraco Workflow installed #48

Closed harry-gordon closed 10 months ago

harry-gordon commented 11 months ago

Bug summary

Reproduction steps

This item has been added to our backlog AB#34610

nathanwoulfe commented 11 months ago

Heya @harry-gordon... I thought you might be on the money with the runtime state, but this checked before running the upgrader/installer, so should not be the cause of this issue.

I'll need to have a closer look, but as a workaround for now, if you create the new project, run it, then install Workflow into the freshly-installed Umbraco instance, it will be all good. I'd like to move the Workflow installer to use package migrations too, really just for the additional visibility in the backoffice.

nathanwoulfe commented 10 months ago

Hey @harry-gordon, fix for this was released yesterday as part of 10.3.3 and 12.2.0. Will also be included in 13.0.0 when that arrives in a couple of week's time 🚀

harry-gordon commented 10 months ago

Thanks for the update @nathanwoulfe! I tried 10.3.3 on a couple of projects (our current project and a project I made to test the problem in isolation) and it still seems to be happening? I haven't tested 12/13.

nathanwoulfe commented 10 months ago

That's a bit annoying, could be that the issue I thought I was fixing wasn't the actual cause. I'll revisit and see if I can reproduce.

nathanwoulfe commented 10 months ago

Weird, I can reproduce it again - awesome too that the stack trace doesn't show anything related to Workflow. Time to start digging...

harry-gordon commented 10 months ago

Thanks for the update @nathanwoulfe! Yeah, it's not a helpful exception, there doesn't seem to be a way to find out what requested the DB 🥲 (it was only through careful process of elimination that I worked out it was Workflow). Good luck! 🚀

nathanwoulfe commented 10 months ago

Heya @harry-gordon, I've tracked this one down and squished it. Plan is for a patch for 10 and 12 to coincide with releasing 13 next week. I'm not entirely sure of the root-cause, other than it being related to repositories accessing SqlContext before the database was created (the confusing part being no code was executing other than building the DI container, so I'm still not sure what was actually attempting to access the SQL context). Made some constructor parameters lazy, and patched the licenses library, and it all looks to be ok.

Should be out mid-week next week.

nathanwoulfe commented 10 months ago

And we are live - patches for 10 and 12 were released yesterday.