umbraco / UmbracoDocs

The official Umbraco Documentation
https://docs.umbraco.com
MIT License
270 stars 780 forks source link

Docs on using Models Builder interfaces to render compositions #1151

Closed greystate closed 6 years ago

greystate commented 6 years ago

What type of issue is it?

Missing documentation

What article/section is this about?

Reference/Templating/Modelsbuilder

Describe the issue:

The Models Builder section is missing some docs on how to render data from compositions (without having to use the generic GetPropertyValue() thingy).

So I've started some, but thought I'd get some feedback before I went too crazy overboard :-)

They're in my branch over here for public scrutiny...

jmayntzhusen commented 6 years ago

Hey @greystate

The page on your branch looks good πŸ™‚ I don't know how much you are planning to add to this, I would suggest you either use this issue to keep track of parts and then do PR's little by little or just submit what you have and then see if others add onto it.

We may as well benefit from what is already there πŸ˜‰

greystate commented 6 years ago

Thanks @jmayntzhusen πŸ‘

I'll submit a PR and get the ball rolling from there ⚾️ 🎒

dampee commented 6 years ago

Does that mean that we should merge #1156 as soon as it looks good?

jmayntzhusen commented 6 years ago

I would say so, it works fine at the moment πŸ™‚