umbraco / UmbracoDocs

The official Umbraco Documentation
https://docs.umbraco.com
MIT License
269 stars 780 forks source link

Gulp #961

Closed tiffy74 closed 6 years ago

tiffy74 commented 6 years ago

What type of issue is it? (Choose one - delete the others)

Missing documentation

What article/section is this about?

https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/docs/CONTRIBUTING_DETAILED.md https://github.com/umbraco/UmbracoDocs/blob/master/Development-Guidelines/building-angular-project.md

Describe the issue:

2 issues in one!

First - occasionally there are out of date pages that reference Grunt where they should reference Gulp.

Second - when building through Powershell - the process currently uses Gulp Watch and some (including myself) may not have used Watch in a taskrunner before. Therefore please expand on the guidance to explain the gulp steps and what users should expect to see.

tiffy74 commented 6 years ago

Of course - more than happy to fix these myself if you approve :)

tiffy74 commented 6 years ago

Noticed that Gulp watch is referenced correctly in the angular api documentation. Therefore thinking about some way of linking to it so new devs won't panic :)

sofietoft commented 6 years ago

Hi @tiffy74

We are aware that both of the links you've sent us contains some out-dated information 🙈 Thanks for keeping us on our toes!

The PR you've made, #969 , is for this issue, correct?

-Sofie

tiffy74 commented 6 years ago

Yes @sofietoft - thanks. Although I think it's probably a wider issue than I had realised as @marcemarc has commented on the PR - so more than happy to make wider changes in support of the PR. If anyone else spots any incorrect grunt references then it would be useful if they could use this thread to point them out.

Maybe it would be better to change the name of this thread - perhaps to something like 'Change grunt references to gulp' - what do you think?

tiffy74 commented 6 years ago

Fixed all references to Grunt and replaced with gulp :)

jmayntzhusen commented 6 years ago

Hey @tiffy74 ,

Did #969 cover this issue or are more changes needed? 😊

tiffy74 commented 6 years ago

I think that the main issue is dealt with. The issue with Gulp Watch is secondary really so I'm happy to close off this thread :)