umbrellaplug / umbrellaplug.github.io

Umbrella Kodi Addon Official
122 stars 18 forks source link

[FEATURE] Trakt in Progress TV shows menu item #210

Closed TechXXX closed 1 year ago

TechXXX commented 1 year ago

Feature request

EDIT: I think I know what's going on here, stupid I didn't see it before but after reading a reddit it became obvious, progress in Umbrella isn't Progress from Trakt, it's in progress episodes, not in progress TV shows, can we please have an in progress TV shows menu item from Trakt: https://trakt.tv/users/mijnkodi/progress ? I'll change from Bug to feature request.

I'm hesitating posting this because it's not reproducible but maybe you can help out nonetheless. I'm missing shows from my Trakt progress, i.e. when I look at the website trakt.tv/users/mijnkodi/progress the results don't correspond with what I'm seeing in the Umbrella progress list, some are there but some are missing.

When I add a show manually from the website to see if this one goes missing too it doesn't happen and it shows up on the list without a problem. When I try it on a fresh install with a fresh trakt.tv account, there's no issue. I would delete my trakt.tv account and start fresh were it not that on 2 other addons (seren and tmdb helper) I do see the missing shows. I've also tried Fen's in progress tv shows and I get results but they're completely random i.e. not ordered by date whatsoever. (EDIT: I've managed to at least get them ordered in Fen by altering the settings - Navigation - Sorting)

So on Seren I get my list without missing items on myshows - recently watched and in tmdb helper on trakt - your in-progress shows.

Here's how it looks on the trakt.tv website:

image

And here is a widget from mytvshows - progress (Umbrella):

image

Here's tmdb helper - trakt - your in-progress :

image

As you can see some shows, show up, others don't.

Sorry for the long winded report but I didn't how else to explain it in a more concise way. I'd be more than willing to provide you with my trakt.tv login/password if that would help. By the way, great work on recent fixes, I'm loving the codes being copied to clipboard for trakt and RD.

kodi.log

same behaviour on 19.5, nexus

Expected Result

See the same shows as on trakt.tv/progress .

Steps To Reproduce

login to my trakt account - view progress and compare with Umbrella's mytvshows - progress

Logs, Screenshots, and Additional Info

No response

Checklist

umbrellaplug commented 1 year ago

I see you changed this to a feature request. Just so I'm clear on what to be doing here, you are wanting in-progress tv-shows as well as in-progress episodes?

TechXXX commented 1 year ago

Yes that's exactly it, just what's displayed on trakt.tv/users/xxxx/progress which I believe is 'In progress tv-shows'. In progress episodes just shows unfinished episodes so if you completely watch an episode and then want to watch the next episode the tv show won't show up on the widget. Would be great if you could add it to the menu.

umbrellaplug commented 1 year ago

This is in the works and should be in the next update in the next few days.

TechXXX commented 1 year ago

Great, appreciate you!

umbrellaplug commented 1 year ago

@TechXXX Can you try out the latest test version and see if it looks more like what you're looking for.

TechXXX commented 1 year ago

Ok, I just tried it on a fresh install of 20.1, default skin because on my other installs the sorting was completely off. Now it's almost right but some shows are missing. Here's my trakt progress:

image

and here it is within Umbrella, somehow Beef is missing:

image

Few entries down that 'Commando' show is missing:

image
umbrellaplug commented 1 year ago

I'm thinking that May be due to then being 100% watched and not showing any new episodes available yet. I'd be interested to see if the ones that are showing that are 100% show episodes announced yet for future seasons.

TechXXX commented 1 year ago

South park is also missing, still running and no 100%

image image
TechXXX commented 1 year ago

Isn't it possible to copy the relevant code from tmdb helper's menu item? It displays trakt.tv/progress perfectly.

This is a screenshot from tmdb helper's 'recently watched tv shows' in the Trakt menu:

image
umbrellaplug commented 1 year ago

Okay. I've tried to accommodate here. Telling me just to copy tmdbhelper is insulting. Just use tmdbhelper. I'm closing this issue.

TechXXX commented 1 year ago

I'm sorry about that, didn't mean to insult you. I thought developers borrowed/used each others code all the time for inspiration etc.

umbrellaplug commented 1 year ago

Try the latest test build if you get a chance and see if tv show progress lines up better to trakt.

Umbrella is already doing a lot of the same thing tmdbhelper is doing with the code. Tmdbhelper ha over 800 lines of code for just it's progress section. It's not a simple thing to "just take a look at". The current episode behavior in progress seems to mimic tmdbhelper, but with some elimination of episodes. If venom123 was still around I could ask him why, but I'm not sure. I matched the new tv show progress up to what I see on trakt.tv when I compare my progress. Hopefully this is what people are looking for. I'm not 100% sure.

TechXXX commented 1 year ago

Ah you seem to have nailed it, your progress tv shows even caught/displayed a show I watched that Trakt didn't register in trakt.tv/users/mijnkodi/progress/ , namely Futurama, I'm betting because it's an unaired season. The rest of the shows are in perfect order as it's displayed on the website, so it not only displays trakt.tv/progress but improves it! Well done.

I would have never guessed the relevant code was 800 lines of code, I was thinking a couple, 5 max. Please don't take offense on account of my ignorance. I realise inheriting code from previous devs must be frustrating without being able to consult them but you seem to have come up with a working solution. Thanks a lot and keep up the good work!