umbrellaplug / umbrellaplug.github.io

Umbrella Kodi Addon Official
110 stars 17 forks source link

[BUG] Playnext popup not showing #307

Closed SJ1O closed 10 months ago

SJ1O commented 11 months ago

Bug

Ok I been playing around it was working but then it suddenly stops showing the playnext popup and won't come show again unless restart Kodi or delete umbrella cache ect.

It's like sometimes it fails to create a playlist possibly?

I have tried changing all the playnext settings but it always stops showing. Mainly when changing shows ect.

Here is a log in hoping you can find something in there.

https://paste.kodi.tv/cuzayaqiwe

Expected Result

Playnext popup to show

Steps To Reproduce

...

I can send you my skin and skin settings files if this helps?

Kodi Version, Type of Device, Logs, Screenshots, and Additional Info

Kodi 20.2 Firecube 3rd gen https://paste.kodi.tv/cuzayaqiwe

Checklist

Omarscomin commented 11 months ago

Maybe it would help if the general Umbrella cache was added to the "cache" portion of Umbrella's settings, which allows you to configure exactly when you want the cache for specific data to auto-clear. Then, we could set it to auto-clear every hour or 2. I try not to be a compulsive cache cleaner, but I usually end up being "forced" to clear it almost daily, for one reason or another. Idk, just throwing out ideas!

umbrellaplug commented 11 months ago

Maybe it would help if the general Umbrella cache was added to the "cache" portion of Umbrella's settings, which allows you to configure exactly when you want the cache for specific data to auto-clear. Then, we could set it to auto-clear every hour or 2. I try not to be a compulsive cache cleaner, but I usually end up being "forced" to clear it almost daily, for one reason or another. Idk, just throwing out ideas!

I cannot remember the last time I cleared the cache on my setup. If you're having issues to a point of needing to clear your cache daily something is wrong. I'm going to write in some logging for the playnext so that it's a little more clear where in the code you guys are making it to before the popup stops happening.

I'm in the process of working on a fix for the arctic fuse skin to allow for the ah2 style popup to show correctly. In that process I found a new "arctic fuse style" popup being used for upnext in the new skin. I will likely create a new option for arctic fuse style also. I'm seeing an issue where sometimes a playlist is not being sent when starting an episode from certain places within the skin. There's code in Umbrella to catch those times and generate a playlist so I'm curious as to what is causing this to fail. I'm also looking into adding multiple seasons into Playnext so I will be looking at that playlist building code for that as well.

Let me get these changes in place and I will have you both try out the next test version to see if the logging can help to track down what's happening.

SJ1O commented 11 months ago

Maybe it would help if the general Umbrella cache was added to the "cache" portion of Umbrella's settings, which allows you to configure exactly when you want the cache for specific data to auto-clear. Then, we could set it to auto-clear every hour or 2. I try not to be a compulsive cache cleaner, but I usually end up being "forced" to clear it almost daily, for one reason or another. Idk, just throwing out ideas!

I cannot remember the last time I cleared the cache on my setup. If you're having issues to a point of needing to clear your cache daily something is wrong. I'm going to write in some logging for the playnext so that it's a little more clear where in the code you guys are making it to before the popup stops happening.

I'm in the process of working on a fix for the arctic fuse skin to allow for the ah2 style popup to show correctly. In that process I found a new "arctic fuse style" popup being used for upnext in the new skin. I will likely create a new option for arctic fuse style also. I'm seeing an issue where sometimes a playlist is not being sent when starting an episode from certain places within the skin. There's code in Umbrella to catch those times and generate a playlist so I'm curious as to what is causing this to fail. I'm also looking into adding multiple seasons into Playnext so I will be looking at that playlist building code for that as well.

Let me get these changes in place and I will have you both try out the next test version to see if the logging can help to track down what's happening.

You sir are a legend!!! Really looking forward to this it sounds like it's gunna be a awesome update. And I'm glad you have managed to narrow down on the playlist issue

Omarscomin commented 11 months ago

Maybe it would help if the general Umbrella cache was added to the "cache" portion of Umbrella's settings, which allows you to configure exactly when you want the cache for specific data to auto-clear. Then, we could set it to auto-clear every hour or 2. I try not to be a compulsive cache cleaner, but I usually end up being "forced" to clear it almost daily, for one reason or another. Idk, just throwing out ideas!

I cannot remember the last time I cleared the cache on my setup. If you're having issues to a point of needing to clear your cache daily something is wrong. I'm going to write in some logging for the playnext so that it's a little more clear where in the code you guys are making it to before the popup stops happening.

I'm in the process of working on a fix for the arctic fuse skin to allow for the ah2 style popup to show correctly. In that process I found a new "arctic fuse style" popup being used for upnext in the new skin. I will likely create a new option for arctic fuse style also. I'm seeing an issue where sometimes a playlist is not being sent when starting an episode from certain places within the skin. There's code in Umbrella to catch those times and generate a playlist so I'm curious as to what is causing this to fail. I'm also looking into adding multiple seasons into Playnext so I will be looking at that playlist building code for that as well.

Let me get these changes in place and I will have you both try out the next test version to see if the logging can help to track down what's happening.

The main reason I clear the cache almost every day is because I end up doing at least one forced Trakt sync, outside of the scheduled syncs. So it's definitely more of a "user error" kind of thing. Lol.

You really are awesome. Thank you so much for all of your hard work and your willingness to address things that don't always pertain specifically to Umbrella.

Omarscomin commented 11 months ago

Just wanted to throw out there that this issue might somehow be related to setting the popup to appear after the last subtitle. I haven't had any issues ever since switching to the "seconds remaining" option.

umbrellaplug commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Just installed the test repo trying it out now. Very very excited :) will update you with feedback asap. Thanks very much buddy

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Very lovely update. Just tested it and only issue I could find was with the fuse theme pop up window when selecting the play button to start the next episode it just stops playback completely. However the ah2 window works perfectly and seems to be showing every time it should. And also continuing onto the next season. I really like that AH2 theme so I'll be sticking with that one anyway personally. My wife thinks I'm crazy because I was so excited for the update. And you definitely didn't disappoint. 10/10 thanks very much.

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

Omarscomin commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

I'll try it out this evening and provide some feedback tomorrow. Thank you!

umbrellaplug commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

If this is the first time you've installed a test version the pop up is normal. On the test side I run the addon without reuselanguage invoker. On the public side I leave it on by default. That's why you got the pop up. No worries.

Logs would be nice. So play didn't work on fuse theme running on what skin?

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

If this is the first time you've installed a test version the pop up is normal. On the test side I run the addon without reuselanguage invoker. On the public side I leave it on by default. That's why you got the pop up. No worries.

Logs would be nice. So play didn't work on fuse theme running on what skin?

Ahh yes it's was my first time using the test repo. Also I was using the fuse playnext theme while running the fuse theme.

Just tried to replicate the issue and it's working 100% flawlessly now I did restart Kodi so maybe that was the issue.

Here is a log with extra info from the umbrella test addon just in case it's helpful anyway. : https://paste.kodi.tv/ufugiluhuh

Only thing I would recommend is maybe focusing the play button on the fuse theme popup window.

Great job on this update very lovely stuff

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

If this is the first time you've installed a test version the pop up is normal. On the test side I run the addon without reuselanguage invoker. On the public side I leave it on by default. That's why you got the pop up. No worries.

Logs would be nice. So play didn't work on fuse theme running on what skin?

Maybe I spoke to soon.

Just had this notification when expecting the playnext window popup: Episodes nothing was found

Then afew seconds after had this notification.

Umbrella error check log for information

Here is the log: https://paste.kodi.tv/ulagaqetev

umbrellaplug commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

If this is the first time you've installed a test version the pop up is normal. On the test side I run the addon without reuselanguage invoker. On the public side I leave it on by default. That's why you got the pop up. No worries. Logs would be nice. So play didn't work on fuse theme running on what skin?

Maybe I spoke to soon.

Just had this notification when expecting the playnext window popup: Episodes nothing was found

Then afew seconds after had this notification.

Umbrella error check log for information

Here is the log: https://paste.kodi.tv/ulagaqetev

yeah, looks like an error in my logging code. I fixed it and pushing new version to test repo now. your addon should alert you to the update. 6.6.273

SJ1O commented 10 months ago

Just pushed test version to test repo that has more logging for playnext and when it is called. Please test and let me know.

Oh one more thing I did receive this notification when installing the test addon not sure if it means anything. (Reuse Language Invoker SETTING/XML mismatch Umbrella will reload your profile to refresh the addon.xml) and I did receive a notification afew times when starting a stream that no stream was available or something it was very fast and I couldn't catch what it said and I am unable to get it to show again but even tho I got that notification content played still so not sure why. Do you need any logs or anything for the fuse theme window not playing?

If this is the first time you've installed a test version the pop up is normal. On the test side I run the addon without reuselanguage invoker. On the public side I leave it on by default. That's why you got the pop up. No worries. Logs would be nice. So play didn't work on fuse theme running on what skin?

Maybe I spoke to soon. Just had this notification when expecting the playnext window popup: Episodes nothing was found Then afew seconds after had this notification. Umbrella error check log for information Here is the log: https://paste.kodi.tv/ulagaqetev

yeah, looks like an error in my logging code. I fixed it and pushing new version to test repo now. your addon should alert you to the update. 6.6.273

I still seem to be getting a notification quite frequently saying: Episodes nothing was found but it still plays the next episode even though I get this notification. It doesn't seem to affect me at all but just letting you know. Got it on the last two episodes I loaded

Here is the log https://paste.kodi.tv/epiyenuyog

Also the only other thing I would mention besides the unfocused play button on the fuse theme window is the buttons on AH2 theme if you scroll left once or click right twice you are unable to select a button again. (It will no longer focus on any of the buttons) hope that makes sense. Not a big issue at all but just pointing it out

umbrellaplug commented 10 months ago

Okay. Let me see what I can find concerning the Episodes nothing was found. I will also see if I can make adjustments for the button controls on the two playnext windows.

Omarscomin commented 10 months ago

Just wanted to provide some feedback!

Settings/device:

•2019 Nvidia Shield Pro

•AH2 style popup with AH2 skin

•Pop up set to display after last subtitle

•If subtitle option fails, pop up is set to display when there are 30 seconds remaining

Everything worked pretty much perfectly for me. I played the final episode of season 1 of "Dead to Me", and the up next popup appeared, despite it being the end of a season. The pop up appeared as expected for the next several episodes after that.

I then switched over to the first episode of season 4 of "Better Call Saul", and the correct content played without me having to reload the skin! Can't even put into words how much I love that. The pop up appeared as expected for several episodes of "Better Call Saul" as well. The only thing that was kinda weird was that it came up way before the last subtitle in some instances, and way after the last subtitle in other instances. It's definitely a small price to pay, and I'm sure it has to do with a difference in the subtitles that are used to determine when to initiate the pop up.

After that, I played a movie, and the correct content played once again, without me having to reload the skin😁

Thank you so much for this. These are HUGE game changers for binge-watching, for sure!!

Not sure if you need a log for perfection, but here it is! https://paste.kodi.tv/ateniyigoh

Thanks again. You're fucking awesome.

umbrellaplug commented 10 months ago

That's great news. I'm noticing a couple things I'll be pushing a new test version for today. Looks like specials and season 0 episodes are being added to the end of the playlist also when the seasonal playnext is turned on. Also some changes to address the OPs concerns on default button on pop ups and the weird episode pop up he was describing. Should be a new version in a bit to try.

SJ1O commented 10 months ago

That's great news. I'm noticing a couple things I'll be pushing a new test version for today. Looks like specials and season 0 episodes are being added to the end of the playlist also when the seasonal playnext is turned on. Also some changes to address the OPs concerns on default button on pop ups and the weird episode pop up he was describing. Should be a new version in a bit to try.

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at.

Here is the log https://paste.kodi.tv/avokebodoz

Omarscomin commented 10 months ago

That's great news. I'm noticing a couple things I'll be pushing a new test version for today. Looks like specials and season 0 episodes are being added to the end of the playlist also when the seasonal playnext is turned on. Also some changes to address the OPs concerns on default button on pop ups and the weird episode pop up he was describing. Should be a new version in a bit to try.

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at.

Here is the log https://paste.kodi.tv/avokebodoz

I'm having issues with resume points not being removed as well. This applies to movies too. Even after a movie or episode is marked as "watched" in Trakt, the resume points remain, especially if I resume something more than once. The only thing that fixes it is accessing "scrobble reset item" from Umbrella's context menu.

SJ1O commented 10 months ago

That's great news. I'm noticing a couple things I'll be pushing a new test version for today. Looks like specials and season 0 episodes are being added to the end of the playlist also when the seasonal playnext is turned on. Also some changes to address the OPs concerns on default button on pop ups and the weird episode pop up he was describing. Should be a new version in a bit to try.

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I'm having issues with resume points not being removed too. This applies to movies as well. Even after a movie or episode is marked as "watched" in Trakt, the resume points remain, especially if I resume something more than once. The only thing that fixes it is accessing "scrobble reset item" from Unbrella's context menu.

Do you use tmdb helper by any chance? I had my in progress episodes set up via a tmdb helper widget and I think it's only happening when resuming the show via that widget. Just tried it in the umbrella finish watching and it worked fine and removed the resume point. Tried it with 3 in progress episodes without any issues with the play next popup or removel of the resume points

Omarscomin commented 10 months ago

That's great news. I'm noticing a couple things I'll be pushing a new test version for today. Looks like specials and season 0 episodes are being added to the end of the playlist also when the seasonal playnext is turned on. Also some changes to address the OPs concerns on default button on pop ups and the weird episode pop up he was describing. Should be a new version in a bit to try.

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at.

Here is the log https://paste.kodi.tv/avokebodoz

I'm having issues with resume points not being removed too. This applies to movies as well. Even after a movie or episode is marked as "watched" in Trakt, the resume points remain, especially if I resume something more than once. The only thing that fixes it is accessing "scrobble reset item" from Unbrella's context menu.

Do you use tmdb helper by any chance? I had my in progress episodes set up via a tmdb helper widget and I think it's only happening when resuming the show via that widget. Just tried it in the umbrella finish watching and it worked fine and removed the resume point. Tried it with 3 in progress episodes without any issues with the play next popup or removel of the resume points

Nope, not using TMDB for widgets or as a player. I've been wondering if it's a skin issue. I've been waiting to officially report it until I try different skins.

umbrellaplug commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at.

Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

umbrellaplug commented 10 months ago

I'm having issues with resume points not being removed as well. This applies to movies too. Even after a movie or episode is marked as "watched" in Trakt, the resume points remain, especially if I resume something more than once. The only thing that fixes it is accessing "scrobble reset item" from Umbrella's context menu.

This seems like a whole different issue. I'm trying to follow the comments and such here but I'm getting a bit confused.

Omarscomin commented 10 months ago

I'm having issues with resume points not being removed as well. This applies to movies too. Even after a movie or episode is marked as "watched" in Trakt, the resume points remain, especially if I resume something more than once. The only thing that fixes it is accessing "scrobble reset item" from Umbrella's context menu.

This seems like a whole different issue. I'm trying to follow the comments and such here but I'm getting a bit confused.

I'm sorry for creating confusion! They are 2 different issues. I'll open a separate bug report for this issue at a later time.

SJ1O commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

  1. Start a show from a resume point.
  2. Wait for the end of the show for the playnext popup.
  3. This is where I started to have some issues however I noticed that this was only happening when played via a tmdb helper widget as shortly after I decided to test it directly in the umbrella add-on and it worked fine.
umbrellaplug commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

  1. Start a show from a resume point.
  2. Wait for the end of the show for the playnext popup.
  3. This is where I started to have some issues however I noticed that this was only happening when played via a tmdb helper widget as shortly after I decided to test it directly in the umbrella add-on and it worked fine.

Thank you for the steps to reproduce. That's so helpful. I'll check this out. From experience I would say it's likely due to difference in meta data sent when opening a video from umbrella vs tmdbhelper.

I don't use skins or tmdbhelper but I have installed arctic fuse and tmdbhelper to try to troubleshoot these issues. I'll see what I can find.

SJ1O commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

  1. Start a show from a resume point.
  2. Wait for the end of the show for the playnext popup.
  3. This is where I started to have some issues however I noticed that this was only happening when played via a tmdb helper widget as shortly after I decided to test it directly in the umbrella add-on and it worked fine.

Thank you for the steps to reproduce. That's so helpful. I'll check this out. From experience I would say it's likely due to difference in meta data sent when opening a video from umbrella vs tmdbhelper.

I don't use skins or tmdbhelper but I have installed arctic fuse and tmdbhelper to try to troubleshoot these issues. I'll see what I can find.

Yh maybe it's something Todo with how tmdbhelper or the umbrella player used within tmdbhelper creates the playlist. I'm not sure how everything technically works but that's the only time I have run into the issue with the playnext popup not showing was when opening a video via tmdb helper. And these video was also in progress. I must say that this only happened twice it was the last things I done at the end of my previous log. Since then I have tried to replicate the issue and I'm unable Todo so. Not sure why as it seems to be working fine now. Was there nothing that stood out in that log?

SJ1O commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

  1. Start a show from a resume point.
  2. Wait for the end of the show for the playnext popup.
  3. This is where I started to have some issues however I noticed that this was only happening when played via a tmdb helper widget as shortly after I decided to test it directly in the umbrella add-on and it worked fine.

Thank you for the steps to reproduce. That's so helpful. I'll check this out. From experience I would say it's likely due to difference in meta data sent when opening a video from umbrella vs tmdbhelper.

I don't use skins or tmdbhelper but I have installed arctic fuse and tmdbhelper to try to troubleshoot these issues. I'll see what I can find.

Also I don't know if this information is useful but the two times I didn't get a playnext popup the shows resume point was also not removed so it was like I never actually resumed and watched the show. I feel like this somehow could be connected

umbrellaplug commented 10 months ago

I was just testing the play next pop up when playing from resume points and it failed 2 out of 3 times. It also didn't remove the resume point after the show was finished. Might be worth looking at. Here is the log https://paste.kodi.tv/avokebodoz

I don't understand this. Can you reword this or elaborate for me? How are you using resume points with playnext? are you thinking it's going to prompt you to play the next episode AND try to resume a certain point on that episode?

  1. Start a show from a resume point.
  2. Wait for the end of the show for the playnext popup.
  3. This is where I started to have some issues however I noticed that this was only happening when played via a tmdb helper widget as shortly after I decided to test it directly in the umbrella add-on and it worked fine.

Thank you for the steps to reproduce. That's so helpful. I'll check this out. From experience I would say it's likely due to difference in meta data sent when opening a video from umbrella vs tmdbhelper. I don't use skins or tmdbhelper but I have installed arctic fuse and tmdbhelper to try to troubleshoot these issues. I'll see what I can find.

Also I don't know if this information is useful but the two times I didn't get a playnext popup the shows resume point was also not removed so it was like I never actually resumed and watched the show. I feel like this somehow could be connected

I will try to check using some resume points. The logs you are posting are your kodi logs, but it looks like either you've got umbrella set to log to a seperate umbrella log or you do not have debug logging turned on in the addon. Can you enable that please? It will give much more logging on the playnext windows. I added a lot of logging for those popups, but it will not show unless debug logging is turned on in the addon.

SJ1O commented 10 months ago

Ohh my bad I did enable debug logging in umbrella but I kept selecting Kodi - upload log file to pastebin. Rather then umbrella - upload log file to pastebin. I'll try replicate it again on a fresh log and submit the umbrella log this time. I did change my in progress widgets to umbrella rather then tmdb as I felt that was the easiest way to avoid this issue. But I'll try replicate the issue so you can try look into the cause

umbrellaplug commented 10 months ago

Ohh my bad I did enable debug logging in umbrella but I kept selecting Kodi - upload log file to pastebin. Rather then umbrella - upload log file to pastebin. I'll try replicate it again on a fresh log and submit the umbrella log this time. I did change my in progress widgets to umbrella rather then tmdb as I felt that was the easiest way to avoid this issue. But I'll try replicate the issue so you can try look into the cause

This is very likely the solution.

Let give you a bit of a breakdown of how the playnext stuff works. When you select an episode, if playnext is enabled all the episodes from the season you selected are added to your playlist. If you use the kodi remote you can actually see this happen by starting an episode and switching to playlist view on the controller. This only happens though if you select the episode from inside the season view. If you start an episode from a widget like ah2 widgets on homepage or some other skin the view does not have the other episodes for that season. I wrote code into the addon to detect when you have playnext turned on but a single episode is sent into the playlist. I gather the rest of the episodes for that season and add them to the playlist. This is how I fixed "playnext doesn't work from widgets" last year. With this latest update I've now enhanced that to add any episodes from additional seasons as well. The code will detect if you came from a season view and all the episodes for that season are already on the playlist and add remaining seasons or if only a single episode was passed like from a widget it will gather all remaining episodes from current season and remaining seasons and add them to the playlist.

Playnext takes your method for detection of the end of an episode (time remaining, percent, or last subtitle time) and shows the playnext window at that point if there are anymore more episodes detected past the current episode on the playlist. This is the reason that playnext requires your settings for kodi for play to be "next episode", it's literally just skipping to the next item in the playlist under the hood.

I explain all of this so that you can have an understanding of how this is all working and a better understanding of things that might cause a hiccup.

All of that being said, this is likely the exact reason the upnext bullshit from the skin isn't working right for. There's no telling what playlist jurial is passing in or how it's being handled. I can look into it, but being entirely transparent here I would spend all of my time fixing things if I made a change in umbrella for every option/ feature/ idea a skin developer decided to implement. This is why a lot of developers just flat out refuse to support skins. I try to meet in the middle and do my best to make them work with each other, but some things like that "upnext" aren't worth it. Not saying I'm not going to check it out or anything, I'm just trying to be 100% with you about that one.

SJ1O commented 10 months ago

Ohh my bad I did enable debug logging in umbrella but I kept selecting Kodi - upload log file to pastebin. Rather then umbrella - upload log file to pastebin. I'll try replicate it again on a fresh log and submit the umbrella log this time. I did change my in progress widgets to umbrella rather then tmdb as I felt that was the easiest way to avoid this issue. But I'll try replicate the issue so you can try look into the cause

This is very likely the solution.

Let give you a bit of a breakdown of how the playnext stuff works. When you select an episode, if playnext is enabled all the episodes from the season you selected are added to your playlist. If you use the kodi remote you can actually see this happen by starting an episode and switching to playlist view on the controller. This only happens though if you select the episode from inside the season view. If you start an episode from a widget like ah2 widgets on homepage or some other skin the view does not have the other episodes for that season. I wrote code into the addon to detect when you have playnext turned on but a single episode is sent into the playlist. I gather the rest of the episodes for that season and add them to the playlist. This is how I fixed "playnext doesn't work from widgets" last year. With this latest update I've now enhanced that to add any episodes from additional seasons as well. The code will detect if you came from a season view and all the episodes for that season are already on the playlist and add remaining seasons or if only a single episode was passed like from a widget it will gather all remaining episodes from current season and remaining seasons and add them to the playlist.

Playnext takes your method for detection of the end of an episode (time remaining, percent, or last subtitle time) and shows the playnext window at that point if there are anymore more episodes detected past the current episode on the playlist. This is the reason that playnext requires your settings for kodi for play to be "next episode", it's literally just skipping to the next item in the playlist under the hood.

I explain all of this so that you can have an understanding of how this is all working and a better understanding of things that might cause a hiccup.

All of that being said, this is likely the exact reason the upnext bullshit from the skin isn't working right for. There's no telling what playlist jurial is passing in or how it's being handled. I can look into it, but being entirely transparent here I would spend all of my time fixing things if I made a change in umbrella for every option/ feature/ idea a skin developer decided to implement. This is why a lot of developers just flat out refuse to support skins. I try to meet in the middle and do my best to make them work with each other, but some things like that "upnext" aren't worth it. Not saying I'm not going to check it out or anything, I'm just trying to be 100% with you about that one.

I just tried testing it again and it worked flawlessly 5 out of 5 times. I think it's time we call it good. I'm definitely over the moon with how it's working and I wouldn't want you to waste your time trying to make your perfectly working addon work with other add-ons or skins. I have had 100% success rate with the playnext popup while using umbrella and it's worked 99% of time time while going through tmdb helper. In all honesty I feel like either of us trying to get it not to work would be a huge waste of time now. You have gone above and beyond mate I truly appreciate it

SJ1O commented 10 months ago

Okay. Let me see what I can find concerning the Episodes nothing was found. I will also see if I can make adjustments for the button controls on the two playnext windows.

I just noticed the episodes nothing was found notification is due to my in-progress episode widget. I don't have anything in progress so that notification comes up when that widget is loaded. That solves that mystery:) sorry about that

umbrellaplug commented 10 months ago

Great. I know you closed this as completed but I actually found part of the reason you weren't getting playnext on arctic fuse sometimes. I'll be pushing another update on test repo later with a few fixes in it.

SJ1O commented 10 months ago

Great. I know you closed this as completed but I actually found part of the reason you weren't getting playnext on arctic fuse sometimes. I'll be pushing another update on test repo later with a few fixes in it.

I thought I'd leave you to close this one as complete when your good and ready :) I did close another issue as complete it was regarding shows not resuming but since changing my widgets from tmdb to umbrella I no longer had that issue so thought I'd close that one. And that's awesome mate although it has been near perfect in this test repo tbh. But if you managed to find something that needed fixing awesome.

umbrellaplug commented 10 months ago

Yeah, try the latest test version. I did a lot of changes there. Unfortunately, it's going to set you back to default colors again (sorry). I made changes for the colors, changes for settings for speed improvements, and I think I fixed a long running bug in umbrella where if playnext comes up and you press stop and then play something else it still plays whatever was queued up from playnext. All in all this should be a pretty noticeable difference for update and is likely going to release once a few testers have had a chance to give it a good run.

SJ1O commented 10 months ago

Yeah, try the latest test version. I did a lot of changes there. Unfortunately, it's going to set you back to default colors again (sorry). I made changes for the colors, changes for settings for speed improvements, and I think I fixed a long running bug in umbrella where if playnext comes up and you press stop and then play something else it still plays whatever was queued up from playnext. All in all this should be a pretty noticeable difference for update and is likely going to release once a few testers have had a chance to give it a good run.

That's cool man no need to be sorry. Setting colours will only take afew seconds. It definitely seems more snappier so that's nice. I noticed the playnext popup not appear when I resumed a show. Here is the log.

https://paste.kodi.tv/ivaruyovik

But just to put it out there this not a issue worth spending hours trying to fix especially if it works in stock Kodi skin. Skin users would just need to accept this hiccup. And I don't want us to keep going round in circles as you give me a very detailed explanation yesterday as to why this might happen. So just updating you with a extra info umbrella log incase it is useful. Still testing the play next window and seems to be working fine 100% of the time other then this one time. But I am totally happy with how it functions now. The next season playnext works wonderfully and I'm also getting the playnext window so happy days

SJ1O commented 10 months ago

Also I been using the play random from the context menu alot. Really cool feature can't believe I have only just noticed it. I was just wondering is it possible to have a playlist created after starting a show using the play random? Just curious and thought I would ask. Hope we haven't knocked years of your life over the last few days with all these posts

SJ1O commented 10 months ago

Test version feedback.

All Playnext Themes work wonderfully and are displayed correctly.

Settings as to when the playnext popup window is shown work flawlessly. Some adjustments could be made to the subtitle settings as previously mentioned sometimes subs run right untill the last few seconds causing the playnext window to only be shown for afew seconds.

The continue to next season setting works flawlessly.

Playnext seems to be very temperamental when using play random via the context menu sometimes it works sometimes it doesn't more often not.

The old playlist no longer carries over the old loaded show when starting a new show now. Example you watch Simpsons S1 ep 2 you get to the playnext window but decide to exit out and load American dad and Simpsons S1 ep3 strats playing. This is no longer the case the correct content always playes so that's awesome.

As for speed It probably does seem abit faster and more responsive although for me it's never been slow at doing anything so that's really hard to judge. I scrape and have content playing within 6/9 seconds. My umbrella widgets load very fast I do use some tmdb helper widgets and umbrella widgets on my home page and that loads all 7 widgets within 15 seconds from startup so very nice considering I'm using a firecube 3rd gen.

Overall very pleased with the test version the new features and bug fixes all work perfectly. Great work with this update

umbrellaplug commented 10 months ago

Test version feedback.

All Playnext Themes work wonderfully and are displayed correctly.

Settings as to when the playnext popup window is shown work flawlessly. Some adjustments could be made to the subtitle settings as previously mentioned sometimes subs run right untill the last few seconds causing the playnext window to only be shown for afew seconds.

The continue to next season setting works flawlessly.

Playnext seems to be very temperamental when using play random via the context menu sometimes it works sometimes it doesn't more often not.

The old playlist no longer carries over the old loaded show when starting a new show now. Example you watch Simpsons S1 ep 2 you get to the playnext window but decide to exit out and load American dad and Simpsons S1 ep3 strats playing. This is no longer the case the correct content always playes so that's awesome.

As for speed It probably does seem abit faster and more responsive although for me it's never been slow at doing anything so that's really hard to judge. I scrape and have content playing within 6/9 seconds. My umbrella widgets load very fast I do use some tmdb helper widgets and umbrella widgets on my home page and that loads all 7 widgets within 15 seconds from startup so very nice considering I'm using a firecube 3rd gen.

Overall very pleased with the test version the new features and bug fixes all work perfectly. Great work with this update

Thank you very much for the feedback on test version. I'm looking forward to pushing this to release as I think most will likely enjoy this update.

Play random I imagine would have issues with playnext, but I will look at that code and see how that play random function is passing in the item or playlist.

On the Playnext with subtitles I'm going to go ahead and write something in now for a hard limit. I'm thinking 20-30 seconds.

The speed will be an ongoing battle. Currently changes were made for colors and how they were stored and retrieved from the settings. Sounds like a small thing, but the colors for your settings are used any time a screen is displayed from umbrella like trakt authorizations, scraping, source results. These screens all used the settings to apply the color customizations selected by the user. These types of windows and screen should all be faster now. The next phase of this will be to move the settings to a different method of storage and retrieval like Peter did in Fen. That's a next update type thing though because it's a big job.

I'll make these few adjustments then push another test version so I can test these subtitle changes. Likely will push that version to release though after testing.

SJ1O commented 10 months ago

Test version feedback. All Playnext Themes work wonderfully and are displayed correctly. Settings as to when the playnext popup window is shown work flawlessly. Some adjustments could be made to the subtitle settings as previously mentioned sometimes subs run right untill the last few seconds causing the playnext window to only be shown for afew seconds. The continue to next season setting works flawlessly. Playnext seems to be very temperamental when using play random via the context menu sometimes it works sometimes it doesn't more often not. The old playlist no longer carries over the old loaded show when starting a new show now. Example you watch Simpsons S1 ep 2 you get to the playnext window but decide to exit out and load American dad and Simpsons S1 ep3 strats playing. This is no longer the case the correct content always playes so that's awesome. As for speed It probably does seem abit faster and more responsive although for me it's never been slow at doing anything so that's really hard to judge. I scrape and have content playing within 6/9 seconds. My umbrella widgets load very fast I do use some tmdb helper widgets and umbrella widgets on my home page and that loads all 7 widgets within 15 seconds from startup so very nice considering I'm using a firecube 3rd gen. Overall very pleased with the test version the new features and bug fixes all work perfectly. Great work with this update

Thank you very much for the feedback on test version. I'm looking forward to pushing this to release as I think most will likely enjoy this update.

Play random I imagine would have issues with playnext, but I will look at that code and see how that play random function is passing in the item or playlist.

On the Playnext with subtitles I'm going to go ahead and write something in now for a hard limit. I'm thinking 20-30 seconds.

The speed will be an ongoing battle. Currently changes were made for colors and how they were stored and retrieved from the settings. Sounds like a small thing, but the colors for your settings are used any time a screen is displayed from umbrella like trakt authorizations, scraping, source results. These screens all used the settings to apply the color customizations selected by the user. These types of windows and screen should all be faster now. The next phase of this will be to move the settings to a different method of storage and retrieval like Peter did in Fen. That's a next update type thing though because it's a big job.

I'll make these few adjustments then push another test version so I can test these subtitle changes. Likely will push that version to release though after testing.

Test version feedback. All Playnext Themes work wonderfully and are displayed correctly. Settings as to when the playnext popup window is shown work flawlessly. Some adjustments could be made to the subtitle settings as previously mentioned sometimes subs run right untill the last few seconds causing the playnext window to only be shown for afew seconds. The continue to next season setting works flawlessly. Playnext seems to be very temperamental when using play random via the context menu sometimes it works sometimes it doesn't more often not. The old playlist no longer carries over the old loaded show when starting a new show now. Example you watch Simpsons S1 ep 2 you get to the playnext window but decide to exit out and load American dad and Simpsons S1 ep3 strats playing. This is no longer the case the correct content always playes so that's awesome. As for speed It probably does seem abit faster and more responsive although for me it's never been slow at doing anything so that's really hard to judge. I scrape and have content playing within 6/9 seconds. My umbrella widgets load very fast I do use some tmdb helper widgets and umbrella widgets on my home page and that loads all 7 widgets within 15 seconds from startup so very nice considering I'm using a firecube 3rd gen. Overall very pleased with the test version the new features and bug fixes all work perfectly. Great work with this update

Thank you very much for the feedback on test version. I'm looking forward to pushing this to release as I think most will likely enjoy this update.

Play random I imagine would have issues with playnext, but I will look at that code and see how that play random function is passing in the item or playlist.

On the Playnext with subtitles I'm going to go ahead and write something in now for a hard limit. I'm thinking 20-30 seconds.

The speed will be an ongoing battle. Currently changes were made for colors and how they were stored and retrieved from the settings. Sounds like a small thing, but the colors for your settings are used any time a screen is displayed from umbrella like trakt authorizations, scraping, source results. These screens all used the settings to apply the color customizations selected by the user. These types of windows and screen should all be faster now. The next phase of this will be to move the settings to a different method of storage and retrieval like Peter did in Fen. That's a next update type thing though because it's a big job.

I'll make these few adjustments then push another test version so I can test these subtitle changes. Likely will push that version to release though after testing.

Your most welcome and thanks for your patience throughout this update I imagine it's been very tedious due to the skin issues ect and appreciate you making things work with other skins.

Play random with the playnext actually seemed to work fine with the stock Kodi skin I only tested it afew times and it worked every time. And it seemed like it only didn't work on the fuse skin with certain shows what seemed strange. But don't lose any sleep over this i understand that making things work with other skins is a huge pain.

Yh that seems like a good idea for the playnext with subtitles however its still a much loved unique feature even if some shows play subtitles right until the final seconds.

Honestly I don't like to mentioning about comparing add-ons to other add-ons as it's such a dick move. And if I made a addon and someone said well this one does this. I'd just tell them to go use that addon then simple. But in this case I think it's fine Todo so. I honestly see no difference in terms of speed with umbrella or fen. I can't say I spend much time navigating within add-ons as I have everything I need within widgets. But they definitely scrape and play just as fast as eachother and I don't think it will be possible to make it scrape and play any faster. And ino they display the scrape widow slightly different obviously fen is one widow for scrape and resolve ect and umbrella does it within two windows but I hardly ever actually see the scrape widow it seems to work very fast to fast for me to even count the results most times. I do have it set to display fullscreen with fanart background to. And I have preemptive termination turned on but I just can't imagine this getting any faster. Killer addon mate a real game changer

SJ1O commented 10 months ago

Good afternoon, just loaded up umbrella test v6.6.278 and none of the settings menus will load and it's as if trakt has been disabled and needs re authenticating. I don't know if you no about this issue haven't seen anything mentioned so just brining it to your attention. 20230812_135736

Omarscomin commented 10 months ago

Good afternoon, just loaded up umbrella test v6.6.278 and none of the settings menus will load and it's as if trakt has been disabled and needs re authenticating. I don't know if you no about this issue haven't seen anything mentioned so just brining it to your attention.

20230812_135736

Open Umbrella > Tools > Fix Blank Settings (and maybe clear cache afterwards)

Does that fix it?

umbrellaplug commented 10 months ago

This should be resolved in the latest update pushed today.