search

umbrellaplug / umbrellaplug.github.io

Umbrella Kodi Addon Official
111 stars 17 forks source link

[FEATURE] Section Labels #324

Closed Omarscomin closed 9 months ago

Omarscomin commented 10 months ago

Feature

Hey! I hope you’ve had a great weekend!

I was just wondering if it might be possible for you to tweak Umbrella’s section labels, so that they reflect the category/genre of the content being displayed. It would look a little cleaner, when paired with a skin (see attached photos, since I’m having a hell of a time putting this into words😵‍💫) IMG_4937 IMG_4938

Thank you for considering this, UD!

umbrellaplug commented 10 months ago

This is in the latest test version. In normal umbrella fashion, it's a setting. General section.

Omarscomin commented 10 months ago

https://github.com/umbrellaplug/umbrellaplug.github.io/assets/129215684/690337d7-77e8-4b88-b2a6-eb22ae75f7a7

SJ1O commented 10 months ago

Ahh this seems like a good feature very lovely 🤗

umbrellaplug commented 10 months ago

trim.A9B48044-59E3-4F50-9F25-E090C04C9CAC.MOV

What are you showing here?

Omarscomin commented 10 months ago

trim.A9B48044-59E3-4F50-9F25-E090C04C9CAC.MOV

What are you showing here?

My personal Trakt lists for TV shows are being displayed, but nothing happens when I try to open them. It's not happening for my movie lists though.

adamosborne83 commented 10 months ago

trim.A9B48044-59E3-4F50-9F25-E090C04C9CAC.MOV

What are you showing here?

My personal Trakt lists for TV shows are being displayed, but nothing happens when I try to open them. It's not happening for my movie lists though.

Are the lists showing in trakt? Silly question I know.

Omarscomin commented 10 months ago

trim.A9B48044-59E3-4F50-9F25-E090C04C9CAC.MOV

What are you showing here?

My personal Trakt lists for TV shows are being displayed, but nothing happens when I try to open them. It's not happening for my movie lists though.

Are the lists showing in trakt? Silly question I know.

Yes, and everything shows up as it should when I switch over to the official version of Umbrella.

umbrellaplug commented 10 months ago

I was able to see the issue here. Give me a little bit to look at it. Should only be those lists.. nice testing. Next time add a little context to the video. :)

Omarscomin commented 10 months ago

I was able to see the issue here. Give me a little bit to look at it. Should only be those lists.. nice testing. Next time add a little context to the video. :)

My apologies. The text context was in our Reddit chat, but I wasn't able to post the video on there😬so, half of the info was on Reddit, and half of it was on here🫠lol. Won't happen again!😇

umbrellaplug commented 10 months ago

New test version should have this fixed.

umbrellaplug commented 10 months ago

I went a little nuts making sure that everything got a label, but I did not go all the way into all the "Collection" lists in movies. Those are hard-coded and it's too many lists to manually add names for them.

Omarscomin commented 10 months ago

Personal Trakt lists, box sets/collections, IMDB genres, and IMDB people/actors are still displaying "Umbrella" as the section label.

"Discover" categories (Popular, Most Voted, Trending, etc.) have the appropriate section label😊

Personal Trakt list: image

IMDB Genre: image

Box set/collection: image

"Discover Movies" category: image

Edit: just noticed your comment about "Collections." Sorry!! Ignore that part😊

umbrellaplug commented 10 months ago

Updated to add all that bullshit. let me know if anything else is missing. I added collection titles, I'm sure it won't be enough. 😊