umbrellaplug / umbrellaplug.github.io

Umbrella Kodi Addon Official
111 stars 17 forks source link

[BUG] Umbrella crashes Kodi when navigating to Next Page (2) in My Movies > Collection.n #355

Closed Hemicrusher closed 2 months ago

Hemicrusher commented 2 months ago

Bug

Umbrella crashes Kodi when navigating to Next Page (2) in My Movies > Collection.

When having exactly 20 movies in Collection, which is the max per page, Next Page (2) shows at the bottom. Clicking on Next Page (2) crashes/locks up Kodi, which then has to be killed under Android. If you have 21 movies, then clicking on Next Page (2) takes you to the second page, where movie #21 shows. If you have only 19 movies, then the Next Page (2) does not show.

Also, when there were 21 movies in Collection, I removed one to test with 20, yet Umbrella still showed 21.

I don't know if this is a Trakt issue, or an issue with Umbrella.

Expected Result

With only 20 movies, which is the max per page, Next Page (2) should not appear until another movie is added.

Steps To Reproduce

See above

Kodi Version, Type of Device, Logs, Screenshots, and Additional Info

Kodi 21.0 stable for Android running on an ONN 4K Google TV device

Kodi log file

Checklist

umbrellaplug commented 2 months ago

I'm unable to view that log currently. It's acting like pastebin is down. Are you running a skin?

Hemicrusher commented 2 months ago

I'm unable to view that log currently. It's acting like pastebin is down. Are you running a skin?

I am just running the default skin,....Weird...the log link worked earlier.

I'll reproduce the issue again later tonight when I get home and post a new log.

Thanks!

Hemicrusher commented 2 months ago

I've updated the link to the log file in the OP and HERE.

umbrellaplug commented 2 months ago

This bug was caused by pagination code. I've made a modification to the code to remove the next button in situations where the list of items are equal to the limit. The latest version on test repo should have it fixed.

Hemicrusher commented 2 months ago

This bug was caused by pagination code. I've made a modification to the code to remove the next button in situations where the list of items are equal to the limit. The latest version on test repo should have it fixed.

Thanks!

I really appreciate your hard work with Umbrella!

I'll close this...