umbrellaplug / umbrellaplug.github.io

Umbrella Kodi Addon Official
116 stars 17 forks source link

[BUG] file_url has spaces in the URL, Kodi can't play it #380

Closed ambulancePilot closed 1 month ago

ambulancePilot commented 1 month ago

Bug

When the rd_link is passed to the file_url, it carries any spaces that were present in the URL along with it. For example:

2024-07-15 17:32:42.189 T:8288 error <general>: CFileCache::Open - <https://nyk2-4.download.real-debrid.com/d/XXXXXXXXX/The Kardashians S05E08 This Is My Most Important Job 1080p DSNP WEB-DL DDP5 1 H 264-FLUX[EZTVx.to].mkv> failed to open

Expected Result

The URL should be encoded just prior to being passed to the player such that the URL is in acceptable format and can be played.

Steps To Reproduce

Try to play the above mentioned Kardashians episode (the same torrent).

Kodi Version, Type of Device, Logs, Screenshots, and Additional Info

In order to fix this, I changed line 472 in realdebrid.py to the following:

file_url = quote_plus(self.unrestrict_link(rd_link))

After this, the issue is eliminated. I am not sure if this is the correct way to fix it, so I would appreciate if you could please look into it and address the issue of the URL being passed to the Kodi player with spaces.

Thanks so much for your work in the community.

Checklist

umbrellaplug commented 1 month ago

Good catch. I'll include this in the next update. You'd think rd would be passing those back url encoded, but I guess not. Could also blame stupid file name use but no reason to point fingers when there's an easy enough fix. Next update will have this.

ambulancePilot commented 1 month ago

Thank you so much. It's rare to find a file named like this... figures it's a Kardashian episode 🙄

Thanks again.

On Tue, Jul 16, 2024, 8:23 a.m. umbrellaplug @.***> wrote:

Good catch. I'll include this in the next update. You'd think rd would be passing those back url encoded, but I guess not. Could also blame stupid file name use but no reason to point fingers when there's an easy enough fix. Next update will have this.

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2230755832, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQUQVCVF72AJNFTP7LTLZMUGDFAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQG42TKOBTGI . You are receiving this because you authored the thread.Message ID: @.***>

umbrellaplug commented 1 month ago

I figured if it meant enough to you to admit you were watching Kardashians then I could at least fix it. 😆

ambulancePilot commented 1 month ago

Hahahaha. One year ago I'd have relentlessly made fun of anyone watching this. The other half is into it and I've been watching with him. It's pretty bad.

On Tue, Jul 16, 2024, 12:06 p.m. umbrellaplug @.***> wrote:

I figured if it meant enough to you to admit you were watching Kardashians then I could at least fix it. 😆

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2231311428, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQURO4JTHESAQFAIDHWLZMVAGZAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGMYTCNBSHA . You are receiving this because you authored the thread.Message ID: @.***>

ambulancePilot commented 1 month ago

Oh my. To be honest I don't really watch many movies, so I didn't even think to test with that case. That's so strange! Very hard to imagine how that could happen.

I'll do my best to back trace the error related to playing movies and share what I can, if I find anything.

Can you share what other things have broken? It might help.

I always enjoy a good problem!

On Tue, Jul 16, 2024, 3:27 p.m. umbrellakodi @.***> wrote:

This actually breaks a lot of things. After making this change no movies play from real-debrid. I don't know how you have this working to be honest.

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2231681152, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQUUP2USLWEQVMG3ESXDZMVX3XAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGY4DCMJVGI . You are receiving this because you authored the thread.Message ID: @.***>

ambulancePilot commented 1 month ago

Oh I see! I think I might know how to address it in that case, but I don't want to speak too early and out of turn. Of course the problem isn't really how to solve the issue, but how to solve it without breaking other things.

If you're able to figure anything out please let me know.

In my view it's something that deserves a fixing because in some cases autoplay doesn't work because the number one source has spaces in the file name.

On top of that, because it's not a failure to resolve, it doesn't try the next source. It resolves but it doesn't play, and there's no code to handle that case.

On Tue, Jul 16, 2024, 3:41 p.m. umbrellakodi @.***> wrote:

It broke the resolve function in real debrid and the remove magnet due to the information no longer matching.

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2231701505, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQUVTP6Q5BW3EDQ2VMW3ZMVZNRAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRG4YDCNJQGU . You are receiving this because you authored the thread.Message ID: @.***>

ambulancePilot commented 1 month ago

That's no problem, I'll do my best to sort it out and share if I have a viable fix.

On Tue, Jul 16, 2024, 4:04 p.m. umbrellakodi @.***> wrote:

Really falls back to bad naming for files. It's pretty standard practice not to put spaces in file names. I'll see what I can do, but I'm being very honest when I say it's not something I'll invest a large amount of time into fixing.

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2231734583, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQURTZ7DFINTJU5OVEGLZMV4DFAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRG4ZTINJYGM . You are receiving this because you authored the thread.Message ID: @.***>

ambulancePilot commented 1 month ago

EDIT: I jumped the gun on this, looks like we need to replace square brackets as well. I'm now on a mission to figure out what characters are unacceptable to the player. I'll update this code once I have a comprehensive list of replacements.

I have a feeling once I create the dictionary for replacements and get that Kardashians episode working again, it's going to break something else! But let's see...

Please try this:

file_url = self.unrestrict_link(rd_link) file_url = file_url.replace(" ", "+")

No need to use quote_plus and fuck up the entire URL. It does more to the URL than I thought. It's surprising TV shows even played.

We just need to replace spaces with the plus sign so the Kodi player can interpret the URL. Movies work with this as well as TV shows.

Can you check and see if it breaks anything else? Theoretically it should not as we are only making the requisite change and nothing else.

Thank you for your time! I hope this is the one.

umbrellaplug commented 1 month ago

This is causing other issues with special characters. Can you give me an example of exact file you're dealing with so I can test here?

umbrellaplug commented 1 month ago

"Mars Attacks!" "¡Three Amigos!" just to give a couple examples. I really need to see the actual file and try it myself. I may be able to use a regular expression to adjust it but it'll take a few tries so I could use an example file to work with.

umbrellaplug commented 1 month ago

Also.... I'd be failing myself if I didn't mention. Didn't I read a comment from you on reddit a while back when I was upset about the asshole making a clone of umbrella and being a dick to me that you couldn't wait for chatgpt to be capable to replace people like me so you didn't have to worry about your addons being controlled by crybabies?

If that's the case and something has changed and now you're using Umbrella, that's some wild stuff to say about someone to be on here asking for changes and such like that never happened. I'm not going to be a jerk or lecture here and I'm going to look at your issue you're reporting still, but maybe in the future remember you're talking about a person before you make a statement like that. Try not to light your way forward with the bridges you've burned.

Maybe I'm wrong and that's someone else and in that case I'm sorry, but I don't think I am.

umbrellaplug commented 1 month ago

I just checked this exact file and it works from windows and android. I'm not sure this is an actual issue. Can you provide another example file? Seems like this may have been part of the real debrid issues the past few days.

ambulancePilot commented 1 month ago

Sorry for the late reply, busy with work and whatnot.

Yes, I'm am that dude. I have been clear with what my issues are with the other developer. Now that the red hat is out of the bag, I'm done.

You are professional and take pride in your work. He does not. No one who takes pride in their work makes their product worse out of a personal grudge.

In the end, he's free to do what he wants and I'm free to bitch and complain about it.

To be clear, this is a dude who votes for a guy who wants to destroy the lives of LGBTQ people including myself, amongst other minority groups. Just because he doesn't spew vitriol on reddit doesn't mean he isn't a POS. I haven't met a single Trump supporter in my entire life who had any answer for the people who's lives he plans to diminish. Collateral damage, I guess, right? Fuck those people.

Moving on.

Further inspection shows there is no issue playing torrents that contain video files with spaces in them as long as they are a movie torrent. I confirmed this by playing this torrent through a filterless scrape: https://bitsearch.to/torrents/spider-man-no-way-home-2022-1080p-dual-lat-cinecal-83112/6231dcba427e2e63a76a82d6/

The issue is isolated to episodes. Thus:

if season: return quote_plus(file_url) else: return file_url

I have tested this as much as I can and can't seem to come up with any errors, but I am sure you are more effective at that than I. I hope we can continue to work together, at least on this issue.

Thanks for your time, as always.

umbrellaplug commented 1 month ago

Cool, as I said. not here to lecture or bitch. I can respect at least owning up to previous comments. I'm not always proud of statements I've made either, but I can only try to grow from it.

The red hat shit... ehhh I'll leave that shit alone.

I'm wondering if this is a device thing. linux vs windows vs android. What type of device are you having this issue on? Can you give me exact steps to duplicate because I tried the Kardashians Season 5 Episode 8 and it appeared to match the one you tried to play from rd, but it played for me with no issues without any code changes. I'm not giving you a hard time here. I want to fix the issue, I just need to understand where it's coming into play so I can address it correctly. I'm unable to duplicate on a shield or on my windows lab machine.

ambulancePilot commented 1 month ago

Thank you for your candor.

You might be on to something. I have only tested this on a fire stick 4K max. I do have Kodi installed on my Windows laptop so I will give that a go when I get a chance, but it will have to be tomorrow.

One thing I'd be curious to know is with that Kardashians episode I mentioned, if you're sure it's the same magnet, what URL does the log show after OpenFile?

Does the URL have spaces in it as per the file name or has it been manipulated in some?

On Wed, Jul 17, 2024, 5:08 p.m. umbrellaplug @.***> wrote:

Cool, as I said. not here to lecture or bitch. I can respect at least owning up to previous comments. I'm not always proud of statements I've made either, but I can only try to grow from it.

The red hat shit... ehhh I'll leave that shit alone.

I'm wondering if this is a device thing. linux vs windows vs android. What type of device are you having this issue on? Can you give me exact steps to duplicate because I tried the Kardashians Season 5 Episode 8 and it appeared to match the one you tried to play from rd, but it played for me with no issues without any code changes. I'm not giving you a hard time here. I want to fix the issue, I just need to understand where it's coming into play so I can address it correctly. I'm unable to duplicate on a shield or on my windows lab machine.

— Reply to this email directly, view it on GitHub https://github.com/umbrellaplug/umbrellaplug.github.io/issues/380#issuecomment-2234295401, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATRPQUXWU63YQUE5TRM452LZM3MLFAVCNFSM6AAAAABK5L5QLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZUGI4TKNBQGE . You are receiving this because you authored the thread.Message ID: @.***>

AdeHub commented 1 month ago

Hi

I possibly have the same issue on Apple TV

2024-07-20 20:57:34.836 T:263652    info <general>: VideoPlayer::OpenFile: plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtimZdihwYx5hHJFJFBTWuViPmlT.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D
2024-07-20 20:57:34.836 T:266543    info <general>: Creating InputStream
2024-07-20 20:57:34.836 T:266543   error <general>: CCurlFile::CReadState::FillBuffer - (0x11b24d4e0) Failed: URL using bad/illegal format or missing URL(3)
2024-07-20 20:57:34.836 T:266543   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/JLSHYWDJWPJFQ83/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-20 20:57:34.837 T:266543   error <general>: CCurlFile::CReadState::FillBuffer - (0x11b24d4e0) Failed: URL using bad/illegal format or missing URL(3)
2024-07-20 20:57:34.837 T:266543   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/JLSHYWDJWPJFQ83/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-20 20:57:34.837 T:266543   error <general>: CFileCache::Open - <https://syd3.download.real-debrid.com/d/JLSHYWDJWPJFQ83/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> failed to open
2024-07-20 20:57:34.837 T:266543   error <general>: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtimZdihwYx5hHJFJFBTWuViPmlT.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D]

Edit: also doesn't play on my MacBook

saxoloman commented 1 month ago

Same with coreelec

ambulancePilot commented 1 month ago

Hey there sorry about the delay in getting back. Had a busy weekend.

I return with some news. On Windows, the torrent I am talking about plays without issue even though it has spaces in it. The spaces don't affect playback.

2024-07-21 20:00:14.638 T:19032 info <general>: VideoPlayer::OpenFile: https://nyk1-4.download.real-debrid.com/d/xxxxxxxx/The Kardashians S05E08 This Is My Most Important Job 1080p DSNP WEB-DL DDP5 1 H 264-FLUX[EZTVx.to].mkv 2024-07-21 20:00:15.080 T:4424 info <general>: Creating InputStream 2024-07-21 20:00:16.065 T:4424 info <general>: Creating Demuxer 2024-07-21 20:00:18.431 T:4424 info <general>: Opening stream: 0 source: 256

So spaces in the file_url don't impede playback on Windows and Shield TV. But playback fials on MacBook, CoreElec, and Fire Stick. Definitely device dependent.

The reason I went with the code above (if season etc) is because I noticed in the log that the debrid link isn't passed to the player, but an umbrella:// link is passed (in the case of movies only). Maybe I'm wrong but is that the reason spaces in the file_url don't affect movies?

So that's why I thought adding quotes_plus to just the file_url for episodes would be a good option.

Have you any thoughts?

umbrellaplug commented 1 month ago

I have a MacBook. I should be able to come up with a solution now that I have a way to duplicate the issue. Let me look at what's happening and what you've attempted and I'll get back with you.

umbrellaplug commented 1 month ago

Unable to duplicate this so far. I tried with a MacBook running BigSur. I'm wondering if I will see this issue on an intel chipset. I doubt it. I have a dual boot on this device so I will try with a newer version of Mac (Sonoma) and see if that makes a difference. Otherwise I'll have to start looking at what other devices I have around here to try to duplicate this.

umbrellaplug commented 1 month ago

Thus far this works on big sur, sonoma, pibox, sheild, windows, xbox series x.

Let me try to load my apple tv device up. I don't have a firestick 4k or any of that coreelec shit.

umbrellaplug commented 1 month ago

Apple TV no issue either. Am I trying the wrong files here? 2024-07-22 11:21:30.023 T:19178 info : VideoPlayer::OpenFile: plugin://plugin.video.umbrella/?action=play_Item&title=This+Is+My+Most+Important+Job&year=2022&imdb=tt15791630&tmdb=154521&tvdb=414093&season=5&episode=8&tvshowtitle=The+Kardashians&premiered=2024-07-11&meta=%7B%22premiered%22%3A+%222024-07-11%22%2C+%22season_isAiring%22%3A+%22true%22%2C+%22seasoncount%22%3A+10%2C+%22plot%22%3A+%22Kim+and+Kourtney+face+new+chapters+of+motherhood%2C+while+Kris+struggles+to+process+her+upcoming+surgery.+The+whole+family+gets+together+for+a+photoshoot+before+Kim+heads+to+New+Orleans+to+meet+with+Gypsy+Rose+Blanchard.%22%2C+%22tmdb%22%3A+%22154521%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2Fy5tqHu7Rly3RS9uJZqTTraf7mQ2.jpg%22%2C+%22season_poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2Fy5tqHu7Rly3RS9uJZqTTraf7mQ2.jpg%22%2C+%22season%22%3A+5%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Kris+Jenner%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2F2XHSec5q7NxXh5WCSTeVdGTT6mI.jpg%22%7D%2C+%7B%22name%22%3A+%22Kourtney+Kardashian+Barker%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2FdE3CztdZ1leY94HP2CIEQaXnexg.jpg%22%7D%2C+%7B%22name%22%3A+%22Kim+Kardashian%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2FcTuLiimHK338z9qCTurMIqFoQ25.jpg%22%7D%2C+%7B%22name%22%3A+%22Khlo%5Cu00e9+Kardashian%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2F9KozpelrLI11rGVnP81ZHqAxGsx.jpg%22%7D%2C+%7B%22name%22%3A+%22Kendall+Jenner%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2FccREiRWn47w1yYLKNzosFYq8ok.jpg%22%7D%2C+%7B%22name%22%3A+%22Kylie+Jenner%22%2C+%22role%22%3A+%22Self%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2FhQx8UnvYSSJfsDqvwgvvZpnDSzu.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+8%2C+%22tmdb_epID%22%3A+5366448%2C+%22title%22%3A+%22This+Is+My+Most+Important+Job%22%2C+%22duration%22%3A+2820%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw500%2Fr5mAAdlPyjm8vZy2MYNG754Bk1o.jpg%22%2C+%22rating%22%3A+10.0%2C+%22votes%22%3A+1%2C+%22tvshowtitle%22%3A+%22The+Kardashians%22%2C+%22year%22%3A+%222022%22%2C+%22imdb%22%3A+%22tt15791630%22%2C+%22tvdb%22%3A+%22414093%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22US%22%5D%2C+%22total_seasons%22%3A+5%2C+%22counts%22%3A+%7B%221%22%3A+10%2C+%222%22%3A+10%2C+%223%22%3A+10%2C+%224%22%3A+10%2C+%225%22%3A+10%7D%2C+%22studio%22%3A+%22Hulu%22%2C+%22genre%22%3A+%22Reality%22%2C+%22mpaa%22%3A+%22TV-14%22%2C+%22status%22%3A+%22Returning+Series%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw780%2FqRHu9tSD2CKf10IlFr5FztO4Rxh.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw342%2Fy5tqHu7Rly3RS9uJZqTTraf7mQ2.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F414093%2Ftvbanner%2Fthe-kardashians-6290969fe950a.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Fw780%2Fyd17TqEcvP9FcbtRNtZpcLCOhFj.png%22%2C+%22extended%22%3A+true%2C+%22next_episode_to_air%22%3A+%7B%22air_date%22%3A+%222022-02-10%22%2C+%22episode_number%22%3A+7%7D%2C+%22label%22%3A+%22This+Is+My+Most+Important+Job%22%2C+%22code%22%3A+%22tt15791630%22%2C+%22imdbnumber%22%3A+%22tt15791630%22%2C+%22tag%22%3A+%5B%22tt15791630%22%2C+%22154521%22%5D%7D 2024-07-22 11:21:30.428 T:20938 info : Creating InputStream 2024-07-22 11:21:31.254 T:20938 info : Creating Demuxer 2024-07-22 11:21:32.415 T:20938 info : Opening stream: 0 source: 256 2024-07-22 11:21:32.416 T:20938 info : Creating video codec with codec id: 27

umbrellaplug commented 1 month ago

Alright no offense fellas but I'm not going to waste any more time on this trying to find a device that DOESN'T work right. Everything I've tried this on works without any issues. If someone wants to actually turn logging on and provide some actual logs then feel free but I will not be doing anymore troubleshooting here based on snippets of logs or speculation. Closing this issue.

saxoloman commented 1 month ago

@ambulancePilot Can you please share your solution ? Where do i put this lines ? if season: return quote_plus(file_url) else: return file_url

Or can you just share edited file ? I would like to test if this fixes it or not

AdeHub commented 1 month ago

Steps to duplicate on macOS (Monterey):

Source Select Baby Reindeer S01 E03

Screen Shot 2024-07-23 at 7 21 16 AM

Pick a file that has blanks (05 in example)

Screen Shot 2024-07-23 at 7 24 14 AM

Attempt to play...

2024-07-23 07:25:28.030 T:10595645    info <general>: VideoPlayer::OpenFile: plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D
2024-07-23 07:25:28.032 T:10607716   debug <general>: Thread VideoPlayer start, auto delete: false
2024-07-23 07:25:28.033 T:10595645   debug <general>: OnPlayBackStarted: CApplication::OnPlayBackStarted
2024-07-23 07:25:28.035 T:10607716    info <general>: Creating InputStream
2024-07-23 07:25:28.041 T:10607716   debug <general>: CurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv>
2024-07-23 07:25:28.041 T:10607716   debug <general>: easy_acquire - Created session to https://syd3.download.real-debrid.com
2024-07-23 07:25:28.042 T:10607716   error <general>: CCurlFile::CReadState::FillBuffer - (0x7fd043fd17f0) Failed: URL using bad/illegal format or missing URL(3)
2024-07-23 07:25:28.042 T:10607716   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-23 07:25:28.043 T:10607002   debug <general>: Loading settings for plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D
2024-07-23 07:25:28.046 T:10607716   debug <general>: CFileCache::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> opening
2024-07-23 07:25:28.047 T:10607716   debug <general>: CurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv>
2024-07-23 07:25:28.047 T:10607716   error <general>: CCurlFile::CReadState::FillBuffer - (0x7fd0464a5d20) Failed: URL using bad/illegal format or missing URL(3)
2024-07-23 07:25:28.048 T:10607716   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-23 07:25:28.048 T:10607716   error <general>: CFileCache::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> failed to open
2024-07-23 07:25:28.048 T:10607716   error <general>: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D]
2024-07-23 07:25:28.049 T:10607716    info <general>: CVideoPlayer::OnExit()

macOS Logs

https://paste.kodi.tv/inekawucuv https://paste.kodi.tv/axomaciver

Apple TV Logs

https://paste.kodi.tv/jepejakili

ambulancePilot commented 1 month ago

I'll pay a full debug log later tonight, however right off the bat I can foresee the problem has to do with how these different devices are working through the logic. It blows my mind, but the same code is doing different things on different devices.

For example, on my device, anytime you play an episode, the raw and unrestricted link is passed to the Kodi video player. I'm talking about an https:// real debrid link. This is demonstrated by some log snippets I have posted.

On your device, the raw link is not shared with the Kodi video player. An umbrella:// link is shared with the player instead.

This is a critical difference that determines how the device handles the file url and weather spaces in the URL impact the ability to play. When the umbrella:// url is shared with the player, spaces are replaced with either plus signs or %20, both of which are acceptable to the player. When the https:// link is passed to the player, spaces aren't handled.

We won't be able to fix this issue at the root unless we figure out why different devices pass different file URLs to the Kodi player, and even after that, the goddamn video still plays somehow. It's mind-blowing.

I suppose the true solution to this problem would be to find out why https:// URLs are being passed to the player on some devices.

I'll post a full debug log with the problem replicated this evening.

Thanks again for your time!

umbrellaplug commented 1 month ago

Steps to duplicate on macOS (Monterey):

Source Select Baby Reindeer S01 E03

Screen Shot 2024-07-23 at 7 21 16 AM

Pick a file that has blanks (05 in example)

Screen Shot 2024-07-23 at 7 24 14 AM

Attempt to play...

2024-07-23 07:25:28.030 T:10595645    info <general>: VideoPlayer::OpenFile: plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D
2024-07-23 07:25:28.032 T:10607716   debug <general>: Thread VideoPlayer start, auto delete: false
2024-07-23 07:25:28.033 T:10595645   debug <general>: OnPlayBackStarted: CApplication::OnPlayBackStarted
2024-07-23 07:25:28.035 T:10607716    info <general>: Creating InputStream
2024-07-23 07:25:28.041 T:10607716   debug <general>: CurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv>
2024-07-23 07:25:28.041 T:10607716   debug <general>: easy_acquire - Created session to https://syd3.download.real-debrid.com
2024-07-23 07:25:28.042 T:10607716   error <general>: CCurlFile::CReadState::FillBuffer - (0x7fd043fd17f0) Failed: URL using bad/illegal format or missing URL(3)
2024-07-23 07:25:28.042 T:10607716   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-23 07:25:28.043 T:10607002   debug <general>: Loading settings for plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D
2024-07-23 07:25:28.046 T:10607716   debug <general>: CFileCache::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> opening
2024-07-23 07:25:28.047 T:10607716   debug <general>: CurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv>
2024-07-23 07:25:28.047 T:10607716   error <general>: CCurlFile::CReadState::FillBuffer - (0x7fd0464a5d20) Failed: URL using bad/illegal format or missing URL(3)
2024-07-23 07:25:28.048 T:10607716   error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

2024-07-23 07:25:28.048 T:10607716   error <general>: CFileCache::Open - <https://syd3.download.real-debrid.com/d/TF273XFPNDJ3S78/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> failed to open
2024-07-23 07:25:28.048 T:10607716   error <general>: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.umbrella/?action=rescrapeMenu&title=Episode+3&year=2024&imdb=tt13649112&tmdb=241259&tvdb=417223&season=1&episode=3&tvshowtitle=Baby+Reindeer&premiered=2024-04-11&meta=%7B%22premiered%22%3A+%222024-04-11%22%2C+%22season_isAiring%22%3A+%22false%22%2C+%22seasoncount%22%3A+7%2C+%22plot%22%3A+%22Donny+takes+some+time+off+from+the+pub+and+tries+to+make+amends+with+Teri.+But+no+matter+how+much+he+avoids+Martha%2C+he+can%27t+escape+her+for+long.%22%2C+%22tmdb%22%3A+%22241259%22%2C+%22poster%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22season%22%3A+1%2C+%22castandart%22%3A+%5B%7B%22name%22%3A+%22Richard+Gadd%22%2C+%22role%22%3A+%22Donny+Dunn%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Ft5x4PjeJg9ELGToI0kGsTLcBkdf.jpg%22%7D%2C+%7B%22name%22%3A+%22Jessica+Gunning%22%2C+%22role%22%3A+%22Martha+Scott%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fc4nC6usiZdRlw4VkOcHFLXtrPa0.jpg%22%7D%2C+%7B%22name%22%3A+%22Nava+Mau%22%2C+%22role%22%3A+%22Teri%22%2C+%22thumbnail%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fu8cS0PxTVnNJQeWItZdcr6JxrBs.jpg%22%7D%5D%2C+%22mediatype%22%3A+%22episode%22%2C+%22episode%22%3A+3%2C+%22director%22%3A+%22Weronika+Tofilska%22%2C+%22writer%22%3A+%22Richard+Gadd%22%2C+%22tmdb_epID%22%3A+5227315%2C+%22title%22%3A+%22Episode+3%22%2C+%22duration%22%3A+2340%2C+%22episode_type%22%3A+%22standard%22%2C+%22thumb%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2F39YGnnlZisihAO5yJzo31StWWLm.jpg%22%2C+%22rating%22%3A+7.765%2C+%22votes%22%3A+17%2C+%22tvshowtitle%22%3A+%22Baby+Reindeer%22%2C+%22year%22%3A+%222024%22%2C+%22imdb%22%3A+%22tt13649112%22%2C+%22tvdb%22%3A+%22417223%22%2C+%22aliases%22%3A+%5B%5D%2C+%22country_codes%22%3A+%5B%22GB%22%5D%2C+%22total_seasons%22%3A+1%2C+%22counts%22%3A+%7B%221%22%3A+7%7D%2C+%22studio%22%3A+%22Netflix%22%2C+%22genre%22%3A+%22Drama%22%2C+%22mpaa%22%3A+%2218%22%2C+%22status%22%3A+%22Ended%22%2C+%22fanart%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2FtTGhI7lqd4frPS6XzR0d5gcXTMc.jpg%22%2C+%22icon%22%3A+%22https%3A%2F%2Fimage.tmdb.org%2Ft%2Fp%2Foriginal%2Fe5MUdXRjl90Up5dAEdvsGs4zAAS.jpg%22%2C+%22banner%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvbanner%2Fbaby-reindeer-664ded6c604a3.jpg%22%2C+%22clearlogo%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Fhdtvlogo%2Fbaby-reindeer-662e2d5b4f249.png%22%2C+%22landscape%22%3A+%22https%3A%2F%2Fassets.fanart.tv%2Ffanart%2Ftv%2F417223%2Ftvthumb%2Fbaby-reindeer-6634f95e9ceaa.jpg%22%2C+%22extended%22%3A+true%2C+%22label%22%3A+%22Episode+3%22%2C+%22code%22%3A+%22tt13649112%22%2C+%22imdbnumber%22%3A+%22tt13649112%22%2C+%22tag%22%3A+%5B%22tt13649112%22%2C+%22241259%22%5D%7D]
2024-07-23 07:25:28.049 T:10607716    info <general>: CVideoPlayer::OnExit()

macOS Logs

https://paste.kodi.tv/inekawucuv https://paste.kodi.tv/axomaciver

Apple TV Logs

https://paste.kodi.tv/jepejakili

My macbook did not have this issue. It's intel based. I believe that's the difference. My appletv did not have this issue. I'm not sure why it's doing it on yours but not mine. I have a FireStick that I'm loading up fresh now and I will see if I can duplicate there. This is getting a bit ridiculous.

umbrellaplug commented 1 month ago

Worked as expected on firestick 4k as well. Explain what I'm doing differently that makes this work for me every single time on every device?

https://paste.kodi.tv/mofudekefi

umbrellaplug commented 1 month ago

Duplicated it. This is due to torrentio. I'll look at my logs and figure out why now.

umbrellaplug commented 1 month ago

Can someone try the version on the test repo and let me know if this issue is resolved now?

https://umbrellakodi.github.io

ambulancePilot commented 1 month ago

I'll try that version on the test repo as soon as I get home, within the hour.

If you managed to fix it, that's great! I'll review code changes but would love to understand from you how the scraper managed to have such a downstream effect? Does that mean this is a Coco issue?

Would love to learn a little.

Thanks again!

Apologies for not being more active with logs, work's been heavy.

umbrellaplug commented 1 month ago

The fix was close to what you were attempting to do with the substituting " " with "+". Instead of making changes to the realdebrid.py the change was made in sources.py. On line 1286 I added this bit of code to remove any spaces returned from scrapers for the url being sent for the magnet. url = url.replace(" ",".")

It takes the "Janky Title From Magnet Url" and makes it "Janky.Title.From.Magnet.Url" before sending it to be resolved. The key was to do it this way so that it would be passed to any debrid provider without the spaces not just real debrid (not everybody uses real debrid, think about the other people)😆 I was able to figure this out by looking at the logs the other guy provided earlier and his screenshot showing the file was coming from torrentio. For some reason torrentio will return results with spaces in them for the magnet url. This fix should resolve it for all debrid providers without making any changes to what is passed back from coco. I don't use the same scrapers that are public so my results were different than both of you guys. Once I turned all providers off with only torrentio the problem became easier to find. I haven't had one fail yet since making this change, but I can only test so much.

umbrellaplug commented 1 month ago

I'll try that version on the test repo as soon as I get home, within the hour.

If you managed to fix it, that's great! I'll review code changes but would love to understand from you how the scraper managed to have such a downstream effect? Does that mean this is a Coco issue?

Would love to learn a little.

Thanks again!

Apologies for not being more active with logs, work's been heavy.

Longest hour of my life. 🤣

AdeHub commented 1 month ago

Hi, not sure this is working for me, seems to be coming in to this bit as I get that in the log

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L173

saxoloman commented 1 month ago

Thank you,but this didnt fix the issue for me

umbrellaplug commented 1 month ago

Responses have no logs. I've waited two days for the original poster to not even reply or test then two other people to come in with responses without logs that make no sense. Good luck with this issue.

ambulancePilot commented 1 month ago

Apologies friend. I thought I explained work had been very busy. I had no time to test. This is not a personal thing. I'm a bit confused as to why you think you're doing me a favor here by looking into an issue with your code.

I admit I should have updated and told you I had no time until Friday. I figured it would be assumed that people are busy with life. I should not have committed to testing that night within the hour. It was not feasible.

If you're still interested, I will post full debug logs with logging turned on in umbrella and coco scrapers On Friday. I don't foresee anything coming up, but if something does, I'll do my best to update you before then.

Even if you're fixed does not work, I sincerely appreciate the time you've put into this. Making your add-on better is a win for everyone.

umbrellaplug commented 1 month ago

I'm a bit confused as to why you think you're doing me a favor here by looking into an issue with your code.

You should have left this statement off. You opened an issue, that's why I'm looking into it. No worries though, I won't be anymore.

AdeHub commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

umbrellaplug commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

AdeHub commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21 Logs https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

umbrellaplug commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

Is this using latest test version from today?

ambulancePilot commented 1 month ago

I may have time to do a little bit of testing tonight. If not, I'll reply back here.

Everyone, please please post full debug logs even if you don't think it's relevant. Saying something doesn't work isn't helpful.

Dev, I hope you're still willing to work on the issue either with me or by yourself. We made it as far as being able to reproduce the issue reliably. It would be a shame to give up now.

AdeHub commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

Is this using latest test version from today?

v6.6.624

umbrellaplug commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

Is this using latest test version from today?

v6.6.624

Latest is 6.6.625

AdeHub commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

Is this using latest test version from today?

v6.6.624

Latest is 6.6.625

Not seeing this version, how do I refresh? Edit: found it

No difference with 6.6.625

https://paste.kodi.tv/vuyoziroxo https://paste.kodi.tv/fopalirica

umbrellaplug commented 1 month ago

The url appears to be correct but I think it's using something else in player.py, it's going in to the else block but I don't know how it then gets the url

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L155

As a test if you set debridPackCall to True then it plays

https://github.com/umbrellaplug/umbrellaplug.github.io/blob/6f9e7d4aff57dac701aa8ab4e54969b71e913b3c/omega/plugin.video.umbrella/resources/lib/modules/player.py#L138C7-L138C21

Logs

https://paste.kodi.tv/nokaxisapu https://paste.kodi.tv/zuyecozewu

I think this is a different issue. Please try the same thing with the default kodi skin.

No difference with default skin

Is this using latest test version from today?

v6.6.624

Latest is 6.6.625

Not seeing this version, how do I refresh? Edit: found it

No difference with 6.6.625

https://paste.kodi.tv/vuyoziroxo https://paste.kodi.tv/fopalirica

I'm looking through your logs. Thank you for providing full logs. I'm seeing the code change I made to encode the url is working here:

Umbrella Log - Line 50:

[2024-07-26 10:59:02] [ plugin.video.umbrella: DEBUG ]: From func name: resources.lib.debrid.realdebrid.add_magnet() Line # :668
                       msg : Real-Debrid: Sending MAGNET to cloud: magnet:?xt=urn:btih:abe4a2960b2e8feb4b9390656366f48fc8efc27a&dn=Baby.Reindeer.S01E03.Episode.3.1080p.NF.WEB-DL.DDP5.1.Atmos.H.264-FLUX

Kodi Log - Line 1106 2024-07-26 10:59:04.378 T:14354634 error <general>: CCurlFile::Open - <https://syd3.download.real-debrid.com/d/JBRKIHLQJQVBW99/Baby Reindeer S01E03 Episode 3 1080p NF WEB-DL DDP5 1 Atmos H 264-FLUX[EZTVx.to].mkv> Failed with code 0:

It's failing 2 milliseconds later with the url being sent without the encoding. I need to track what's causing this to happen. I'm unable to duplicate this with the code changes so it's making it more difficult to track. The exact same episode from the exact same source plays correctly for me. I'd be interested to hear back from the others reporting problems here but I don't expect good feedback.

ambulancePilot commented 1 month ago

https://paste.kodi.tv/asetofisem.kodi

Hello friend. Unfortunately the fix does not work. Looking at the log I can confirm that the magnet link is being encoded properly. That being said, I don't believe the magnet link was ever an issue. Looking at past logs, even when the magnet link is passed un-encoded, it does not cause any issues. RD is able to deal with the URL however it is sent.

However, the Kodi player is not. I believe this means the URL must be encoded at the final stage just before it is sent to the player. My thoughts only. I will explore this avenue and report back very soon.

Thanks for your continued efforts.

umbrellaplug commented 1 month ago

This would be a change in the player.py. I wrote a new function into the control module on the last version that allows for a url to be sent to that function and returns it encoded. I'll make that change and push a new test version out in a bit.

ambulancePilot commented 1 month ago

Yep, you got it.

Adding this line to player.py fixes it entirely, I'm sure:

url = quote_plus(url, safe='/:~_-.*')

I modified the play_source function in player.py and made the first line of the function the above. I'm not sure how you encoded your URL because I wasn't able to get requote_uri to work, so I used quote_plus with exceptions. This ensures the URL is encoded before it is passed to the player in all cases.

I look forward to seeing your fix! Would you be open to comparing who's code is cleaner and less resource intensive?