Keeps Crashing.....

[adamosborne83]

https://paste.kodi.tv/oqijesogul

Curious, where did you fork venom from? Just I found out today, that if forked from somewhere I particular there is a code in it, that could be causing an issue....

[adamosborne83]

[umbrellaplug]

I've been wondering about my libraries used if it might have been an issue with the requests module being used in python. I bet this is an issue. I'm wonder if this is probably the source of #2 Issue also.

My original files came from a download of the last zip file venom posted before he washed his hands of it. I wasn't able to get a true fork before venom came down. The package I used was 6.5.6

[adamosborne83]

I've been wondering about my libraries used if it might have been an issue with the requests module being used in python. I bet this is an issue. I'm wonder if this is probably the source of #2 Issue also.

My original files came from a download of the last zip file venom posted before he washed his hands of it. I wasn't able to get a true fork before venom came down. The package I used was 6.5.6

I'm in a telegraph channel and asking questions now, haha

[umbrellaplug]

I likely broke this yesterday with my custom timeout nonsense trying to troubleshoot an "Episode Not being Marked" issue. I'm checking it now. Watch for an update in the next few to fix this.

[adamosborne83]

I likely broke this yesterday with my custom timeout nonsense trying to troubleshoot an "Episode Not being Marked" issue. I'm checking it now. Watch for an update in the next few to fix this.

No worries, thank you and sorry to be a pain...

[adamosborne83]

Here is another log, don't know if it will help or not....

But after I watch anything it crashes

Https://paste.kodi.tv/disunoviwo

[umbrellaplug]

What about ezra or kingpin? Do you get an crashes or anything with those? Your requests module matches mine. What are you searching for? I'm wondering if there's a special character or something hitting the scraper. Are you doing it from tmdbhelper? Can you please give me steps to re-produce the issue. I have a windows kodi 19.4 environment and a kodi 19.3 android environment and my requests module in both matches yours. @kodifitzwell is correct in that the module is downloaded from kodi not the plugin. It's shared among all your plugins.

[adamosborne83]

What about ezra or kingpin? Do you get an crashes or anything with those? Your requests module matches mine. What are you searching for? I'm wondering if there's a special character or something hitting the scraper. Are you doing it from tmdbhelper? Can you please give me steps to re-produce the issue. I have a windows kodi 19.4 environment and a kodi 19.3 android environment and my requests module in both matches yours. @kodifitzwell is correct in that the module is downloaded from kodi not the plugin. It's shared among all your plugins.

Hey, I do not use Ezra or Kingpin so I am not in a position to say, I use a mix of library item for movies and point my widgets and my tv lists through umbrella. This happens on both library movies and TV shows through umbrella directly.

I am on a firecube using kodi 19.4.

[adamosborne83]

So these crashes have happened on The Boys and Stranger things.

They are on my widgets coming from Trakt Trending within tv shows.

Skin I use us auramod

[adamosborne83]

Another log haha.

Https://paste.kodi.tv/ujiregopoz

[Wilson-Fisk]

What about ezra or kingpin? Do you get an crashes or anything with those? Your requests module matches mine. What are you searching for? I'm wondering if there's a special character or something hitting the scraper. Are you doing it from tmdbhelper? Can you please give me steps to re-produce the issue. I have a windows kodi 19.4 environment and a kodi 19.3 android environment and my requests module in both matches yours. @kodifitzwell is correct in that the module is downloaded from kodi not the plugin. It's shared among all your plugins.

Hey, I do not use Ezra or Kingpin so I am not in a position to say, I use a mix of library item for movies and point my widgets and my tv lists through umbrella. This happens on both library movies and TV shows through umbrella directly.

I am on a firecube using kodi 19.4.

If you could test kingpin, that would be a help to figure out if the thought issue is the issue or not, default settings are fine

[umbrellaplug]

@Wilson-Fisk is right. He's not just shamelessly promoting. :)

Umbrella and Kingpin are both based of the same venom clone. Umbrella has had a few changes in the past few days to try to track down a issue. If those changes are causing your issue, we will know real quickly if it doesn't happen in kingpin but does in Umbrella.

[adamosborne83]

@Wilson-Fisk is right. He's not just shamelessly promoting. :)

Umbrella and Kingpin are both based of the same venom clone. Umbrella has had a few changes in the past few days to try to track down a issue. If those changes are causing your issue, we will know real quickly if it doesn't happen in kingpin but does in Umbrella.

I am more than happy to try kingpin, but obviously that it will not work on movies in my library, as I used Umbrella for my movies and kingpin will be unable to read them.

[umbrellaplug]

Is the crash occurring every time at the end of watching an epsiode?

[adamosborne83]

Is the crash occurring every time at the end of watching an epsiode?

Well it has just taken me 6 attempts to watch stranger things episode.... cleared cache, provider cache etc and still wasn't playing ball. Very peculiar. Fresh kodi install. Auramod Openwizard Tmdbh Umbrella.

Not an over loaded set up either.

[adamosborne83]

Spoke too soon 10 mins into an episode and crash.

10 crashes today so far haha

Another log

Https://paste.kodi.tv/ozuxuvogej

[adamosborne83]

Kingpins seems OK at present, will report back after I try to watch next episode of stranger things

[umbrellaplug]

Just pushed version 6.5.35 up. Let me know if that resolves your crashing issue. I removed custom timeout and logging statements.

[adamosborne83]

Just pushed version 6.5.35 up. Let me know if that resolves your crashing issue. I removed custom timeout and logging statements.

OK, will try it next. Thank you

[adamosborne83]

Touch wood, seems as good, tried a couple episodes, no crash yet..... Will keep you updated haha. Thank you to all,

[adamosborne83]

Still crashed..... Here is the log..... Https://paste.kodi.tv/gudaradulo Sorry

Guessing it's just me, so I'll go back onto old addon haha

[umbrellaplug]

Try 6.5.36

[adamosborne83]

Try 6.5.36

Will do, my apologies if I am taking advantage of your generous nature with this addon..

[umbrellaplug]

Nah, Crashing is an issue. I haven't been able to duplicate it though. I don't use widgets or anything though so I may not be doing this right. I also have Kodi 19.3 on my android not 19.4, but my windows build is running 19.4. I'm not seeing it there either.

I'm going to try see if I can duplicate the issue. In the 6.5.36 build I removed all my logging. I suspected it was the connection parameter change on timeout causing your issue, but it doesn't look like that's the case as that's been removed and you're still crashing.

[adamosborne83]

Https://paste.kodi.tv/limizivide

[adamosborne83]

Https://paste.kodi.tv/eveculowot

[adamosborne83]

Nah, Crashing is an issue. I haven't been able to duplicate it though. I don't use widgets or anything though so I may not be doing this right. I also have Kodi 19.3 on my android not 19.4, but my windows build is running 19.4. I'm not seeing it there either.

I'm going to try see if I can duplicate the issue. In the 6.5.36 build I removed all my logging. I suspected it was the connection parameter change on timeout causing your issue, but it doesn't look like that's the case as that's been removed and you're still crashing.

Also, when inuse kingpin its fine, I was thinking maybe something got corrupted in kodi on the fresh install, but if kingpin is fine and does not crash I am guessing that it is not the issue.

[umbrellaplug]

Yep, your issue is a fix I did for anime in the scrapers. Couple of minutes I'll have you fixed up.

[adamosborne83]

Yep, your issue is a fix I did for anime in the scrapers. Couple of minutes I'll have you fixed up.

Thank you 🙂 one thing I can promise, I will let you know either way haha

[umbrellaplug]

Lol, I appreciate your patience. There was a fix I did in sources.py for $ in titles of shows and movies. I'd like to keep that in there, but you're getting an error from it. I am pushing a new version (yeah i know) 6.5.37 that should clean that up for you. Instead of removing the code I have put it in the try statement after checking for a none type. This SHOULD resolve your issue. and it actually was in plugin not scrapers. I haven't looked, but I'm pretty sure kingpin doesn't have this in it and may be the difference in the crashes.

[adamosborne83]

Lol, I appreciate your patience. There was a fix I did in sources.py for $ in titles of shows and movies. I'd like to keep that in there, but you're getting an error from it. I am pushing a new version (yeah i know) 6.5.37 that should clean that up for you. Instead of removing the code I have put it in the try statement after checking for a none type. This SHOULD resolve your issue. and it actually was in plugin not scrapers. I haven't looked, but I'm pretty sure kingpin doesn't have this in it and may be the difference in the crashes.

Haha bugger me, it's you who has the patience. I am just someone complaining about a free addon and your free time. Looking forward to the update. Cheers again,

[umbrellaplug]

Update pushed. Just compared. Kingpin does not have this "fix" lol. @Wilson-Fisk If the crashing stops for him after this, you may want to look into this fix. It's to enable searching for titles with a "$" in the title. A lot of the time you don't get results for these because of the $ being a property value in so many languages that it just kinda makes the scrapers crumble. It's used all the time in anime titles though so I wanted to replace anyone searhing "Ca$h" with "Cash" when trying to get links.

[umbrellaplug]

Yeah the titles are all checked in the source_utils.py. I think yes, we could probably put the title replace in clean titles module, but I was concerned about what else it might replace. So when I'm searching for movie... I need the $ for the title, but when I search for sources. I do not want the $ sign. That's why I put it in sources. Is that the best way to do it? I'm sure probably not... :)

[umbrellaplug]

@adamosborne83 Has your crashing been resolved?

[umbrellaplug]

does everything get passed through cleantitle.py? maybe use title = title.replace('\$','s') there instead of sources.py.

notice the \$ escapes the dollar sign. @kodifitzwell I have noticed you around here and there. I didn't want you to think your plugin was being ignored. Is POV public? I notice you have a repo for zips, but no source up. If you would like I can add the info for plugin into my readme also. I'm all for options. I believe you forked the my account change also right?

[adamosborne83]

@adamosborne83 Has your crashing been resolved?

I am afraid not

Kingpin still OK, as soon as I try umbrella it crashes. Here is log.

Https://paste.kodi.tv/haquxegema

[umbrellaplug]

@adamosborne83 and here we go again. Can you please try 6.5.38? Removed the title change completely. Should match Kingpin now.

[umbrellaplug]

I'm trying to follow his setup he had earlier. But I feel like I'm missing a bunch. I installed AuraMod and it has like 97 steps....

@adamosborne83 Can you give me the steps you take to create your widget your using to play videos? I have all the plugins and skins you mentioned earlier. I'm trying to duplicate the crash. I can't.

[Wilson-Fisk]

I'm trying to follow his setup he had earlier. But I feel like I'm missing a bunch. I installed AuraMod and it has like 97 steps....

@adamosborne83 Can you give me the steps you take to create your widget your using to play videos? I have all the plugins and skins you mentioned earlier. I'm trying to duplicate the crash. I can't.

If @adamosborne83 would want to, it might be easier to revoke all his auths and just zip the userdata and addon folders and send his whole setup. Auramod takes a lot of setting up, and has a ton of settings and sub settings through it.

Regardless, skins and widgets really shouldn't matter unless they are being run through tmdbhelper, which can cause other problems

[umbrellaplug]

I'm trying to follow his setup he had earlier. But I feel like I'm missing a bunch. I installed AuraMod and it has like 97 steps.... @adamosborne83 Can you give me the steps you take to create your widget your using to play videos? I have all the plugins and skins you mentioned earlier. I'm trying to duplicate the crash. I can't.

If @adamosborne83 would want to, it might be easier to revoke all his auths and just zip the userdata and addon folders and send his whole setup. Auramod takes a lot of setting up, and has a ton of settings and sub settings through it.

Regardless, skins and widgets really shouldn't matter unless they are being run through tmdbhelper, which can cause other problems

TMDBHelper is a requirement of this skin. Along with a bunch of other nonsense. I'm digging the look, but all the nonsense that came with it is really looking ridiculous to me. I'm simple though. Im seeing a crazy amount of errors in my log now trying to follow his same exact path playing a video from the skin, using tmdbhelper, passing to umbrella as a player it hasn't crashed on me yet. but i also never did anything with the other addon he mentioned. "open wizard".

lol, i'm also on the latest version I hadn't heard back from him yet on. I guess I might roll back to 6.5.37 with the title replace still in there and see if I can get it to crash then. I know my log looks a ton more like his now. just error after error.

[Wilson-Fisk]

TMDBHelper is a requirement of this skin. Along with a bunch of other nonsense. I'm digging the look, but all the nonsense that came with it is really looking ridiculous to me. I'm simple though. Im seeing a crazy amount of errors in my log now trying to follow his same exact path playing a video from the skin, using tmdbhelper, passing to umbrella as a player it hasn't crashed on me yet. but i also never did anything with the other addon he mentioned. "open wizard".

lol, i'm also on the latest version I hadn't heard back from him yet on. I guess I might roll back to 6.5.37 with the title replace still in there and see if I can get it to crash then. I know my log looks a ton more like his now. just error after error.

Yea so quick just for the future, in cases like auramod, it's just a dependency, it pulls things like the artwork, and the info that the skin uses like the crew info, cast, some artwork, ratings, etc. Tmdbhelper really isn't a problem by itself, but can cause problems when used with it's player functions (usually doesn't cause much issue) or its library integration (which can definitely cause problems)

[umbrellaplug]

@Wilson-Fisk Totally get it. He mentioned it earlier in his list of addons he had. I have installed where i needed to test and make sure my json files were working for it for the players section. I don't have the library integration turned on, I'm not sure if he does. I haven't messed with it much. I'm getting ready to try stranger things again with the title replace back in the code. (its only back in mine). Hopefully I can get it to crash so I can figure out the issue.

I haven't been able to reproduce it or had anyone else report it, so I'm starting to wonder if it's not related to his setup. That's the tough part with maintaining these plugins. Got to find the happy middle ground of being helpful vs wasting your time troubleshooting setup issues.

[adamosborne83]

@Wilson-Fisk Totally get it. He mentioned it earlier in his list of addons he had. I have installed where i needed to test and make sure my json files were working for it for the players section. I don't have the library integration turned on, I'm not sure if he does. I haven't messed with it much. I'm getting ready to try stranger things again with the title replace back in the code. (its only back in mine). Hopefully I can get it to crash so I can figure out the issue.

I haven't been able to reproduce it or had anyone else report it, so I'm starting to wonder if it's not related to his setup. That's the tough part with maintaining these plugins. Got to find the happy middle ground of being helpful vs wasting your time troubleshooting setup issues.

Apologies, it got to midnight and I passed out. I donuse your library integration, but I did on venom too. Nothing different whatsoever in set up. I'm going to try a total clean install of kodi.

I'll report back later, thank you again

[adamosborne83]

OK, total fresh installation.

This is the log, still crashes. Kills me..... Sorry think, I will have to give up. Is odd though, as Venom worked fine and so did the fork of venom I previously used. Gutted, as you seem engaged in helping.

Https://paste.kodi.tv/vonasomaze

[adamosborne83]

Odd behaviour is, that movies are fine, both library and through trending trakt.

Only happens on TVShows

[adamosborne83]

[umbrellaplug]

If you're done messing with it I totally understand. I'd be annoyed as a user as well. If you feel like messing with it again I'm happy to keep looking into this.

You're version of umbrella should be almost identical to kingpin. The only difference would at this point would be icons, a clear cache function for icons and textures added, and the scrapers updated. Which leads me down the path of maybe it's a result I'm getting with my scrapers that's not coming in with kingpin.

When it crashes, does it reboot the Kodi or is it just stopping playback and returning to home screen? On my android build I was able to get it to completely crash Kodi yesterday with "the boys" but it was due to the hvec video it was trying to play.

What hardware are you using for this? I may try to get the same hardware to duplicate the issue here.

Can you turn on debugging on Kodi and try a show that has crashed umbrella for you? If it does, grab log, play exact same show from kingpin then grab log again?

If your okay with trying a few more things let me know.

[adamosborne83]

If you're done messing with it I totally understand. I'd be annoyed as a user as well. If you feel like messing with it again I'm happy to keep looking into this.

You're version of umbrella should be almost identical to kingpin. The only difference would at this point would be icons, a clear cache function for icons and textures added, and the scrapers updated. Which leads me down the path of maybe it's a result I'm getting with my scrapers that's not coming in with kingpin.

When it crashes, does it reboot the Kodi or is it just stopping playback and returning to home screen? On my android build I was able to get it to completely crash Kodi yesterday with "the boys" but it was due to the hvec video it was trying to play.

What hardware are you using for this? I may try to get the same hardware to duplicate the issue here.

Can you turn on debugging on Kodi and try a show that has crashed umbrella for you? If it does, grab log, play exact same show from kingpin then grab log again?

If your okay with trying a few more things let me know.

Good Eve, The only reason I'd stop, is to give you a break haha.... this is your time you're giving me for free.

I do not have it show dolby vision, as I am using a Samsung TV.

I use a 2nd Gen FireCube, which I have always got on fine with.

I will do what you have asked for. I am not around as much this eve, so might be a bit more sporadic with logs etc.

Thank you again for your time.

[adamosborne83]

Https://paste.kodi.tv/emekuduvuv

[adamosborne83]

So it seems to be crashing when I get to the end of an episode or film.

Https://paste.kodi.tv/fupogobaye