umccr / RNAsum

Pipeline for generating RNAseq-based cancer patient reports
https://umccr.github.io/RNAsum/
Other
7 stars 4 forks source link

Rmd refactor (part 5) #88

Closed pdiakumis closed 1 year ago

pdiakumis commented 1 year ago

Better handling of package conflicts. First up: most of the changes are simple pkgA::fun1 -> fun1 changes, so this isn't as big as it looks ;-)

pdiakumis commented 1 year ago

@skanwal thanks for your patience with this, I resolved some conflicts with your branch so I think it's ready for review/merge now. I've stopped at the Manta-fusion prep stage since I need to have a better understanding of the SV requirements there, plus the Manta parsing has changed a bit since we rely on gpgr now. You've been following along with my commits so don't think I need to get into details. In summary I refactored:

pdiakumis commented 1 year ago

@skanwal ready for review/merge whenever you get some time. I've reached the end of the data prep stage (hooray!), leaving it in your hands now to see if you can also reach that stage without errors. It renders for me up to and including the goi_summary_table chunk. Next we'll need to tackle the prose in the rendered report and start testing/comparing with real data.