umccr / RNAsum

Pipeline for generating RNAseq-based cancer patient reports
https://umccr.github.io/RNAsum/
Other
7 stars 4 forks source link

exprTable: use unique cuts/values for DT styleInterval #93

Closed pdiakumis closed 1 year ago

pdiakumis commented 1 year ago

The CSS map created by DT::styleInterval in the exprTable Datatable contains heaps of duplicate entries. e.g. for a single call to that function we get this in the HTML:

isNaN(parseFloat(value)) ? '' :
value <= 40.2 ? \"rgb(150,150,255)\"
: value <= 40.2 ? \"rgb(150,150,255)\"
: value <= 40.2 ? \"rgb(150,150,255)\"
: value <= 40.2 ? \"rgb(150,150,255)\"
: value <= 40.2 ? \"rgb(150,150,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(151,151,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(152,152,255)\"
: value <= 40.2 ? \"rgb(153,153,255)\"
: value <= 40.2 ? \"rgb(153,153,255)\"
: value <= 40.2 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(153,153,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"
: value <= 41 ? \"rgb(154,154,255)\"

I believe this is the root cause of Chrome freaking out and not being able to display the expression tables correctly and has thus resulted in users needing to open the HTML report in Safari (which copes with this fine). I'll play a bit with the intervals and see.

victorskl commented 1 year ago

Portal Release - Snowshoe: RNAsum Chrome bug fix