search

umccr / RNAsum

Pipeline for generating RNAseq-based cancer patient reports
https://umccr.github.io/RNAsum/
Other
7 stars 4 forks source link

exprTable: dedup breaks for DT #96

Closed pdiakumis closed 1 year ago

pdiakumis commented 1 year ago

Adding a fix to master for #93. @skanwal could you test on your master setup whenever you get a chance?

Basically what's happening with the DT in exprTable is that we're getting 1801 quantiles for the expression values, those are then assigned colours, but there are lots of dups. Then you end up in a situation where you have 1,801 comparisons in Javascript like:

ifelse(x <= 10, 
       "blue1", 
       ifelse(x <= 10, 
              "blue2",
              ifelse(x <= 10, 
              "blue3", ...

... which becomes a bit of a mess to handle in particular for a Chrome browser. Here I take the first ('head 1') of the colours assigned to each 'group' of breaks, so we end up with less breaks and colour values. Hopefully this works - it works on my machine!

skanwal commented 1 year ago

Hi @pdiakumis - sure, I am testing it now.

victorskl commented 1 year ago

Portal Release - Snowshoe: RNAsum Chrome bug fix

pdiakumis commented 1 year ago

Merging