umccr / RNAsum

Pipeline for generating RNAseq-based cancer patient reports
https://umccr.github.io/RNAsum/
Other
7 stars 4 forks source link

Docker Buildx GH Actions update #99

Closed alexiswl closed 1 year ago

alexiswl commented 1 year ago

Fixes https://github.com/umccr/RNAsum/issues/98

TODO

alexiswl commented 1 year ago

Thanks for doing that Alexis - is 2.5hrs normal for the Docker build or just due to Bioconductor network issues?

Probably not normal, should be closer to 1.5 hrs. Is it network issues or is 3.14 no longer available? This happened on the build yesterday and then again today? https://github.com/umccr/RNAsum/issues/100

pdiakumis commented 1 year ago

Hm okay, a bit weird, let's just go with this for now (I guess the build succeeded in the end, right?) We've had sort of similar issues when using bioconda for the bioconductor data pkgs.

pdiakumis commented 1 year ago

@alexiswl re: #100 (you got the century there!) I wouldn't spend too much time optimising/debugging the Dockerfile setup; we will probably transition to managing everything via conda (conda-locks) end of next month. If the Bioconductor archive fallback worked, I'd leave it at that for now. We can add renv support too for local dev after that.

In my experience with PCGR's pure conda Docker setup it takes ~30min to build two pretty 'heavy' conda envs (pcgr + pcgrr) for OSX and Linux (and not in parallel either), and generate a pkgdown doc website and build the image, so I think we can save quite a bit of time compared to that normal ~1.5hrs build time we're currently getting.

alexiswl commented 1 year ago

Done, repushed the 0.4.7 tag to master so should be released in the next couple of hours