search

umccr / htsget-rs

A server implementation of the htsget protocol for bioinformatics in Rust
https://samtools.github.io/hts-specs/htsget.html
MIT License
39 stars 9 forks source link

Bump up deploy packages, also solves CVE-2023-35165 and CVE-2022-25883 #196

Closed brainstorm closed 1 year ago

brainstorm commented 1 year ago

Bump up deploy deps, getting this ready to be deployed on the UoM demo account alongside Elsa.

/cc @andrewpatto

brainstorm commented 1 year ago

I think having a pre-commit hook for clippy and fmt is a good idea, but I'm not sure if we should remove the github action because pre-commit is only local? Also I feel like the burden wouldn't be too great - fmt runs pretty quick, and I think any compiling done by clippy would be used by the tests later anyway, right?

Sorry I didn't explain properly: the idea would be to have both pre-commit hooks and CI. Also, perhaps potentially have cargo clippy --fix && git commit && git push so that trivial fixes are applied right away?

mmalenic commented 1 year ago

Ahh, yes, that makes sense. I think that's a good idea, a pre-commit hook would make the dev experience nicer. Happy to use cargo clippy --fix, I wonder if there is a way to show what has been applied too.

brainstorm commented 1 year ago

I wonder if there is a way to show what has been applied too.

git diff? :)