refactor: simplify default resolvers and local storage data

umccr / htsget-rs

A server implementation of the htsget protocol for bioinformatics in Rust

https://samtools.github.io/hts-specs/htsget.html

MIT License

39 stars 9 forks source link

refactor: simplify default resolvers and local storage data #241

Closed mmalenic closed 7 months ago

mmalenic commented 7 months ago

Closes #239, there's no need for the defaults to be any more complicated than a 1-1 mapping.

Changes

Change default resolvers to .* and $0, and default local storage locations to the current directory.
- When running with default settings, data can still be fetched from data/.../<id>.
- Docker examples also work with a 1-1 mapping between the mount point and url paths.

mmalenic commented 7 months ago

So if I understand the description of changes correctly https://github.com/hartwigmedical/hmftools/pull/541 (and other third parties like GA4GH and NBIS) don't need to change their docker run nor client invocations because data/ is greedily matched now via . (instead of (data)/(.)).

Yep, basically, data is now matched like any other path component. If it's present in the directory htsget is launched from (or mounted in the docker container), it can used as a file source, and so can any other directory.