Networking TF: Disabled assigning public IP by default in main-vpc

umccr / infrastructure

Infrastructure as Code at UMCCR

10 stars 8 forks source link

Networking TF: Disabled assigning public IP by default in main-vpc #453

Closed victorskl closed 4 months ago

victorskl commented 4 months ago

Resolves #432

andrewpatto commented 4 months ago

I mean I am sure this does what we are asking of it - so the PR is fine. I cannot comment on what services may then not work if they expect main_vpc to assign them a public IP. (but I presume those who have knowledge of our production loads have a better knowledge of whether anything needs a public IP and is not otherwise requesting it and relying on defaults)

victorskl commented 4 months ago

Yup, Patto. Most production workloads are ok; I have checked them through in dev, stg and prod accounts.

I ping you in here; just to heads-up so that any implication with Elsa works in AGHA account, if leveraged this, if any.

Similar for Stephen oncoanalyser work, etc.

andrewpatto commented 4 months ago

No problems - there are no implications for Elsa