umccr / umccrise

:snake: DRAGEN Tumor/Normal workflow post-processing
https://umccr.github.io/umccrise/
MIT License
22 stars 8 forks source link

Multiqc error with Dragen-4 inputs #136

Closed skanwal closed 1 year ago

skanwal commented 1 year ago

When testing umccrise-v2.2.0 with Dragen v4 input, I am getting following error at multiQC stage:

╭───────────────── Oops! The 'dragen' MultiQC module broke... ─────────────────╮
│ Please copy this log and report it at                                        │
│ https://github.com/ewels/MultiQC/issues                                      │
│ Please attach a file that triggers the error. The last file found was:       │
│ /scratch/working_dir/apgi-2137-umccrise/work/2137__APGI_2137_tumour/multiqc_ │
│ data/relabelled_qc_files/apgi_2137.mapping_metrics.csv                       │
│                                                                              │
│ Traceback (most recent call last):                                           │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/multiqc │
│     output = mod()                                                           │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/modules │
│     samples_found |= self.add_mapping_metrics()                              │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/modules │
│     self.report_mapping_metrics(data_sample, data_readgroup)                 │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/modules │
│     plot=multiqc.plots.table.plot(data_readgroup, own_tabl_headers, pconfig= │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/plots/t │
│     return make_table(dt)                                                    │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/plots/t │
│     val = header["modify"](val)                                              │
│   File "/miniconda/envs/umccrise/lib/python3.7/site-packages/multiqc/modules │
│     col["modify"] = lambda x: x * config.read_count_multiplier               │
│ TypeError: can't multiply sequence by non-int of type 'float'                │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

As per discussion on slack (some where deep in the 100 messages), it was suggested to use -E parameter to skip multiQC stage. However, that might not work as expected due to https://github.com/umccr/umccrise/issues/135.

Longterm solution is to update MultiQC in umccrise to latest version to work with Dragen-4.

pdiakumis commented 1 year ago

Fixed with umccr/umccrise@be820f4579fe22baaf582c9d4ff0fb96a5f9c91a.