search

umco / umbraco-ditto

Ditto - the friendly view-model mapper for Umbraco
http://our.umbraco.org/projects/developer-tools/ditto
MIT License
79 stars 33 forks source link

Deprecate legacy Ditto TypeConverters? #127

Closed leekelleher closed 9 years ago

leekelleher commented 9 years ago

Following a discussion from the Our Umbraco forum...

@JimBobSquarePants: I'm actually quite keen to mark all the other converters internal and only expose the DittoPickerConverter. That actually uses all the others to do the conversion internally anyway. In my Umbraco solutions I have never used the converters. DittoMediaPickerConverter, DittoMultipleMediaPickerConverter, DittoContentPickerConverter

:+1: from me on this, as I only use DittoPickerConverter myself.

I suggest that we mark the "legacy" TypeConverters with the Obsolete attribute, directing developers to use the DittoPickerConverter instead.

Open to discussion, etc.

sniffdk commented 9 years ago

Sounds like an excellent idea :+1:

leekelleher commented 9 years ago

Thanks @sniffdk! :+1:

Closing this, as PR #128 has been opened.