search

umco / umbraco-inner-content

A helper library for Umbraco Doc Type based property editors providing overlays and conversion helpers
https://our.umbraco.org/projects/backoffice-extensions/inner-content/
MIT License
2 stars 16 forks source link

PreValue config - swap dropdown with a "Doc Type Picker" #24

Closed leekelleher closed 5 years ago

leekelleher commented 6 years ago

Rather than using a dropdown, we could do similar to how the DocType "Allow children" permission UI works. Use the overlay directive to display a doctype picker.

https://github.com/umco/umbraco-inner-content/blob/develop/src/Our.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/views/innercontent.doctypepicker.html#L20

This is purely a cosmetic / consistent UI idea.

leekelleher commented 6 years ago

I'm thinking along the lines of the List View's layout control...

capture

Where the "icon" picker would be a document-type, the "Name" and "Layout path" would be for the Name Template and Tab dropdown respectively.

dnwhte commented 5 years ago

Considering tackling this along with #43 since both involve changes to the doctypepicker. You mention "Tab dropdown". Inner Content currently doesn't have a Tab dropdown and supports tabs in the edit view. Are there plans to change this?

leekelleher commented 5 years ago

Ignore the Tab drop-down, we removed the feature in v2.0, 15a7d44d5603d91aa2053b1d773a4d7d0eca347b

dnwhte commented 5 years ago

Quick prototype.

2019-01-18_16-32-46

leekelleher commented 5 years ago

The prototype looks great, thanks! 🎉

Couple of technical points...

  1. Let me know if the JSON value/schema changes for the prevalue data. There are things we can do to manipulate it, in order to keep backwards-compatibility. (I've got code examples where we've done this previously). If there are no changes, then no worries. 🙂
  2. With the PR for this, you mention about #43 too. If you could do them as separate PRs, that'd be great, otherwise it becomes trickier to review.
dnwhte commented 5 years ago

No changes to prevalue data needed. I will submit as a separate PR.

One question, do you feel it is safe to use the existing list classes in core or should I copy the styles and create new classes?

leekelleher commented 5 years ago

I'm happy to use the existing list classes.

leekelleher commented 5 years ago

Closing this ticket as a PR has been submitted. Further discussion can be had on PR #45 - thanks @dnwhte! 🎉