Prefix ContentTypeAliasPropertyKey with an underscore?

[leekelleher]

I'm wondering whether we should prefix the InnerContent specific properties with an underscore?

This would avoid any potential clashes with Umbraco property-alias names.

e.g. ContentTypeAliasPropertyKey = "_contentTypeAlias"

:smirk: maybe a double underscore might look better?

Would there be any technical reasons to not do this? e.g. would Angular work okay with this?

---

@mattbrailsford - No biggie if you don't like the idea 😃

[mattbrailsford]

@leekelleher they are all prefixed with "ic" already

[leekelleher]

@mattbrailsford I was suggesting it as a replacement for the "ic" prefix. Of course, I know we're already using it out in the wild... was more thinking about how to avoid any potential clashes.

I'm happy for this to remain closed, just wanted to ask the question 😈

[mattbrailsford]

Why would '_' clash less than 'ic'?

On 13 Mar 2017 12:43 p.m., "Lee Kelleher" notifications@github.com wrote:

@mattbrailsford https://github.com/mattbrailsford I was suggesting it as a replacement for the "ic" prefix. Of course, I know we're already using it... was more thinking about how to avoid any potential clashes.

I'm happy for this to remain closed, just wanted to ask the question 😈

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/umco/umbraco-inner-content/issues/4#issuecomment-286096558, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgLyX15-0z8zGIcNsp3Yn78QDKcRb3sks5rlToFgaJpZM4LiH-Q .

[leekelleher]

Coz you can't use it as a property alias (in the DocType editor).

[mattbrailsford]

Ahh gotcha, though I still prefer 'ic' as then you know it's ours if someone else implemented something similar.

On 13 Mar 2017 12:47 p.m., "Lee Kelleher" notifications@github.com wrote:

Coz you can't use it as a property alias (in the DocType editor).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/umco/umbraco-inner-content/issues/4#issuecomment-286097303, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgLyZuQJgBf1iYtnTZ4uNa5_c2vjPfUks5rlTrQgaJpZM4LiH-Q .

[mattbrailsford]

Could go '_ic' though I guess? Best of both worlds?

On 13 Mar 2017 12:51 p.m., "Matt Brailsford" me@mattbrailsford.com wrote:

Ahh gotcha, though I still prefer 'ic' as then you know it's ours if someone else implemented something similar.

On 13 Mar 2017 12:47 p.m., "Lee Kelleher" notifications@github.com wrote:

Coz you can't use it as a property alias (in the DocType editor).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/umco/umbraco-inner-content/issues/4#issuecomment-286097303, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgLyZuQJgBf1iYtnTZ4uNa5_c2vjPfUks5rlTrQgaJpZM4LiH-Q .

[leekelleher]

I'm cool to stick with "ic" ... it was just one of those niggles that played on my mind 😉 ...and I'm trying to figure out how we'd actually make the switch over (without borking all existing data).

[mattbrailsford]

There is that :) who would be dumb enough to name a property "icContentTypeAlias" anyway?

On 13 Mar 2017 12:53 p.m., "Lee Kelleher" notifications@github.com wrote:

I'm cool to stick with "ic" ... it was just one of those niggles that played on my mind 😉 ...and I'm trying to figure out how we'd actually make the switch over (without borking all existing data).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/umco/umbraco-inner-content/issues/4#issuecomment-286098683, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgLyc6I74buJPVMZf9RXrzHc0YKeNxTks5rlTxigaJpZM4LiH-Q .

[leekelleher]

Touché! 😻

[leekelleher]

@mattbrailsford LOL, I should have gone with this one...