search

umco / umbraco-inner-content

A helper library for Umbraco Doc Type based property editors providing overlays and conversion helpers
https://our.umbraco.org/projects/backoffice-extensions/inner-content/
MIT License
2 stars 15 forks source link

Feature: Doc Type groups #43

Open dnwhte opened 5 years ago

dnwhte commented 5 years ago

When working with a large number of components it would helpful to be able to categorize them into groups and also search/filter them in the create overlay. I wouldn't mind working on a PR if this is something you'd consider.

leekelleher commented 5 years ago

Good suggestion! I like the idea, happy to review a PR for this feature.

Although, interestingly the Umbraco core's doctype selection (for when creating a new page/node) doesn't have this feature either.

dnwhte commented 5 years ago

Thoughts on this UI for groups?

image

leekelleher commented 5 years ago

I misunderstood the feature request, I thought it was for filtering the Doc Types in the selection modal, (when you said categorise, I'd assumed you'd meant by the Doc Type's name - sorry!)

OK, so grouping Doc Types, while I can see a use-case for it, it feels like an edge-case. (I only say this as I've not had a client requirement/need for this). Do you have an example of your use-case, where this would improve the user's experience?

I'm wondering if you've taken a look at the Embedded Content Blocks package? It has a similar concept.

@mattbrailsford What are your thoughts about this proposed feature?

dnwhte commented 5 years ago

No worries. I can see how my request could be misunderstood.

I submitted a PR for search filtering (#46).

Grouping would come in handy when you have a lot of components types. For example, in our case we'd like to group components by something like text based components, teasers, promotions, feeds, etc.

We did look at Embedded Content Blocks. It wasn't suitable for a couple reasons.

dnwhte commented 5 years ago

I have a working prototype of the groups functionality. It's not backwards compatible ATM.

leekelleher commented 5 years ago

I've renamed this ticket to be about the Doc Type groups. The search filter feature is in PR #46.

dnwhte commented 5 years ago

Coming back to this with renewed interest. I think it would really benefit our editors. I'm willing to submit a PR. Thoughts?

Also, I hope to on the proposed changes to #45 as soon as I can find some time.

leekelleher commented 5 years ago

@dnwhte I've come around to your idea. Considering how the Data Type selection (on the Document Type Editor) is grouped, I can see it making sense when you have a larger number of blocks available.

I'm cool with you submitting a PR 👍 But I must also be honest, since Umb8 was released, I burnt out a little, my enthusiasm/motivation/commitment/mojo (whatever you call it) for our Umb7 packages has somewhat dwindled. With no current plans for future releases, etc. So it's nothing personal if I take a while to respond to PRs, etc. ❤️

dnwhte commented 5 years ago

Completely understandable.

I have additional features I'd like added as well, so I'll probably fork it and run a custom build.

I'll also create a PR here for any feature I do add (including groups) just in case you're interested.