umco / umbraco-inner-content

A helper library for Umbraco Doc Type based property editors providing overlays and conversion helpers
https://our.umbraco.org/projects/backoffice-extensions/inner-content/
MIT License
2 stars 15 forks source link

Ability to change the label used when displaying a Doc Type #6

Closed jamiepollock closed 7 years ago

jamiepollock commented 7 years ago

Hey folks, me again :) this is more of a quality of life change. Not sure about my implementation.

Basically, say you have a series of Doc Types used in Stacked Content; "Twitter Tweet Module", "Facebook Post Module" & "Instagram Post Module" but instead of displaying those names when adding new content you wanted to display; "Twitter Tweet", "Facebook Post" & "Instagram Post".

It might be useful in cases where you don't want to or can't change your Document Type name to meet client friendly naming conventions.

mattbrailsford commented 7 years ago

Personally I think the doc type name should be named accordingly as those should always be "client facing". If you want them accessing some other way in code, just change the DocTypeAlias.

@leekelleher your thoughts?

jamiepollock commented 7 years ago

@mattbrailsford That's fair enough. I'm thinking more for back office drop down lists. Although ideally they should have unique client friendly names.

On 11 Mar 2017, at 06:04, Matt Brailsford notifications@github.com wrote:

Personally I think the doc type name should be named accordingly as those should always be "client facing". If you want them accessing some other way in code, just change the DocTypeAlias.

@leekelleher your thoughts?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

leekelleher commented 7 years ago

@mattbrailsford - I recall why @jamiepollock did this PR, we were working on a project where I'd named the doctypes in a certain way, and when referencing them in Stacked Content, the namings didn't feel right.

In reflection, I think we should keep this simple, and stick with using the doctypes name.

Thanks for the effort @jamiepollock - it is appreciated!

jamiepollock commented 7 years ago

@leekelleher no worries!

On 6 May 2017, at 08:11, Lee Kelleher notifications@github.com wrote:

@mattbrailsford - I recall why @jamiepollock did this PR, we were working on a project where I'd named the doctypes in a certain way, and when referencing them in Stacked Content, the namings didn't feel right.

In reflection, I think we should keep this simple, and stick with using the doctypes name.

Thanks for the effort @jamiepollock - it is appreciated!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.