umd-lhcb / plot_scripts

LHCb analysis plotting and table-making utilities
0 stars 0 forks source link

obsolete/deprecated variables notes for Alex #6

Open CoffeeIntoScience opened 4 years ago

CoffeeIntoScience commented 4 years ago

https://github.com/umd-lhcb/plot_scripts/blob/9fad39c97b49fff19a515d210b37c7b82061718d/src/rdx/plot_phoebe_datamc.cxx#L319

If I'm reading right, this is the mcWeight leaf from the tuple. The mcWeight as calculated in the step1 script is obsolete and it's not even clear to me if the parameters used are even reasonable.

Consider using the calculation here. The conditionals are for allowing the muon pid subsample to be selected, i.e., without the uBDT cut, with the uBDT cut, or with the inverted uBDT cut

https://github.com/umd-lhcb/RDRDstRun1AnalysisPreservation/blob/f78365bfc3000ef70ced2ed271ec42aa866c44af/proc/redoHistos_Dst.C#L1910-L1932

In addition, the proper variable to use for the smeared MC fit variables is XXsmearG, or XXsmearres.

I'll keep looking for any other cases of obsolete/deprecated variables

Happy plotting!