umd-mith / airwaves

Unlocking the Airwaves
https://mith.umd.edu/airwaves/
MIT License
9 stars 2 forks source link

Episode(s) with blank title break browsing #4

Open trevormunoz opened 3 years ago

trevormunoz commented 3 years ago

In verifying that #3 was resolved (🎉 ), I noticed that if an episode has a blank title it is impossible/difficult to reach the episode page via browsing from programs. See e.g. https://unlocking.netlify.app/programs/over-the-back-fence-and-transatlantic-profile/

Screen Shot 2021-03-12 at 9 54 54 AM
edsu commented 3 years ago

I took a look and it appears we have 13 episodes that lack titles:

Since there other places in the web application that display episode titles should we perhaps create a default "Unknown" in the data when one is not currently available?

edsu commented 3 years ago

I see this particular one has been updated in Airtable with a title of Over the Back Fence (date unknown). I think that suggests a way for the fetch-episodes import to assign a temporary episode title using the series title when an episode title is not available?

Screenshot from 2021-03-13 06-32-30

edsu commented 3 years ago

Alternatively I guess the import could fail and alert that the episode needs to be assigned a title.

trevormunoz commented 3 years ago

Based on a comment in Slack, it sounds like @ssapienza found the same list using Airtable and plans to update the underlying data.

+1 to the import in fetch-episodes emitting a warning

edsu commented 3 years ago

npm run fetch-episodes will now print out an error when importing episodes from Airtable that have an empty title. I guess we can leave this open until the data is fixed in Airtable and we have run fetch-episodes to add it to the application.

trevormunoz commented 3 years ago

I think this commit also needs to get moved onto main to address #5

edsu commented 3 years ago

I see this commit on main.