search

umd-mith / airwaves

Unlocking the Airwaves
https://mith.umd.edu/airwaves/
MIT License
9 stars 2 forks source link

CSS Update #8

Closed trevormunoz closed 3 years ago

trevormunoz commented 3 years ago

This pull request re-establishes a CSS baseline by introducing site-wide browser reset, variables, type scale, grid, and standard spacing. The main motivation for this new CSS baseline is to enable mobile-first styles. Consequently most classes for multi-column layout are removed (for now) with the intention that they can be re-implemented using CSS grid on the simplified markup structure.

As part of mobile-first styles, this branch also introduces a minimal version of the site logo in a slimmed down page header which includes a toggle-able site menu on mobile.

Some pages of the site beyond the index page—"Search", "Exhibits", etc—will need further work to bring into alignment with new designs and will look broken temporarily when this branch is merged.

NB: purgecss plugin is active on this branch to support review but should be removed prior to merge.

trevormunoz commented 3 years ago

Oops. And TODO.md should get deleted before merge too

trevormunoz commented 3 years ago

Also, @edsu, I would appreciate your eyes on src/components/nav.js. It appears to work but I am still getting use to hooks so let me know if it could be more robust.

trevormunoz commented 3 years ago

To give some additional clarification, this version of the site is definitely not ready to get pushed to production, it's an interim step intended to set up further work (that can be reviewed on staging) toward the completion of design tasks.

This version is not visually polished in any way

edsu commented 3 years ago

I'll be honest here. I don't understand the scope of these changes. I think iti's more appropriate for @kirstenkeister to weigh in since these changes largely concern her work.