search

umd-mith / sga

Shelley-Godwin Archive
http://shelleygodwinarchive.org/
15 stars 23 forks source link

repaired ODD and RNG for Pgh Frankenstein project #348

Closed ebeshero closed 6 years ago

ebeshero commented 7 years ago

Hi @raffazizzi and @trevormunoz ! As we're gearing up to work with the notebook files to prep for collation, I wanted to make sure we had a fully operable schema. I spent some time with the ODD files this evening, and worked out a few sources of problems (and I think some things just resolved themselves over time as TEI ODDs improved). We now have a working RNG for use on the Pgh-Frankenstein copy of the notebook files, and I figured you might want these files, too.

Note: I compiled a version of the ODD that combined the shelley-godwin-page.odd with the godwin-master.odd, mostly so I could see what I was doing as I was hunting for problems. Ultimately, besides updating the xml-model lines at the top, there was really just one change I needed to make that was causing an error in the RNG: it was the modification of the @hand attribute: it should be made in the att.written classSpec, not in att.transcriptional. (Of course, att.written is a member of att.transcriptional, but the output RNG was calling an error on @hand having two different definitions until I fixed it). I made the change in the shelley-godwin-page.odd as well as in my shelley-godwin-FULL.odd . Hope this is useful!

ebeshero commented 7 years ago

Also, the mith:prefixed attributes are no longer causing any trouble--but I didn't have to change a thing to fix those--just output a new RNG from the ODD. :-)

ebeshero commented 7 years ago

@raffazizzi @trevormunoz I spotted an error in an xml:id in c57.0048 and just corrected it here. (It wasn't visible in the individual files but duplicated an xml:id from an earlier chapter. Easy fix.) I just added the change to this pull request.

ebeshero commented 7 years ago

Two additional small but important corrections @corresp and @xml:id values.