search

umdevclub / umdevclub.github.io-pre-covid-archive

MIT License
2 stars 4 forks source link

Adding Will's Facebook and Github links #52

Closed TheWlr9 closed 6 years ago

TheWlr9 commented 6 years ago

Problem

Will Ritchie does not have Facebook or GitHub links

Solution

Added them in

Implementation

Let's users see my public profiles

Screenshots

None

Testing

Copied Kenny Hong's working template.

ratstache commented 6 years ago

Hey Will, I know this is a simple change but please add some more details in the PR to set an example for anyone else who will be contributing to the project. These are all visible even after they are closed so it's important. You can look at the past PR's as examples or use the PR template here: https://github.com/umdevclub/umdevclub.github.io/wiki/Pull-Request-Template

ratstache commented 6 years ago

LGTM, thanks for making that change Will