umdlife / psdk_ros2

This repository is a ROS 2 wrapper for the DJI PSDK libraries.
https://umdlife.github.io/psdk_ros2/documentation/Introduction.html
Mozilla Public License 2.0
68 stars 20 forks source link

Add low speed data transmission from drone to controller #54

Open Yamboy1 opened 9 months ago

Yamboy1 commented 9 months ago

Feature request

Feature description

After adding a PR #53 for low speed data transmission from the controller to the drone, it would be nice to have low speed data transmission from the drone to the controller. This way we have have custom commands, and request response style communication without requiring an external wifi network like we have in the past.

Implementation considerations

Relevant documentation links:

We've been thinking about this in the context of communication between an M350 RTK and DJI RC Plus, but it should in theory work in other configurations too.

Like #53, I think it would make sense, at least originally, for this to be designed as a text based communication, as this is what the MSDK example uses.

Are you willing to submit a pull request to implement this change?

Not currently as I will no longer be working at the research group where I was working on these drones once #53 is merged, and thus won't be able to test my work. But I do think this is an important feature down the line, and should be implemented by someone. Feel free to ask for more information or considerations though, I'm sure I've missed a couple of things.

biancabnd commented 9 months ago

Hi @Yamboy1, Thank you for your contributions! :confetti_ball: We will definitely look into the PR you have opened and consider the enhancement you are proposing.