search

ume05rw / SharpCifs.Std

SharpCifs.Std is a port from SharpCifs to .NET Standard. Original SharpCifs: https://github.com/zinkpad/SharpCifs
GNU Lesser General Public License v2.1
86 stars 34 forks source link

Question: GetCanonicalPath #3

Closed LukePulverenti closed 7 years ago

LukePulverenti commented 7 years ago

What is the intention here:

https://github.com/ume05rw/SharpCifs.Std/blob/4dd5989b980735b3f0279a5f85f0d626cfd10b19/SharpCifs.STD1.3/Util/Sharpen/FilePath.cs#L131

LukePulverenti commented 7 years ago

Is this a typo, because the results of TrimEnd are not actually being utilized. Thanks !

ume05rw commented 7 years ago

Thanks for your notice!

It was already written like this when I cloned.

I'll check up what they wanted to do...

ume05rw commented 7 years ago

hi!

removed the line that you pointed out.

it seems, tried to mimic the trailing space deletion that the original-jcifs was processing.

System.IO.Path.GetFullPath processed it first, so Nobody was aware of this.

Thanks!