search

umegaya / lua-aws

pure-lua implementation of aws REST APIs
122 stars 35 forks source link

Empty files, fix list serialization #22

Closed ahpeterson closed 8 years ago

ahpeterson commented 8 years ago

Mark empty files as being specifically empty by design.

When serializing queries, remember that arrays in Lua start at 1, so no need to add 1 to the indices.

The member rules are in rules.member, not rules.members.

If a member has a different name, it's called locationName, not name.

Finally, the split routine sometimes leaves a blank entry on the end. Apparently some consumers of the library expect that, but when serializing a list with a custom name it doesn't work right, so look for that and remove it.

This makes the sendMessageBatch and deleteMessageBatch routines work properly for SQS.

umegaya commented 8 years ago

@ahpeterson thank you for submitting pull request, and sorry for late reply, when I try to write test-case of your pull request, I found I did not properly handle shape object building from service definition JSON file. so I create pull request #23. then I will close this pull request because now this is dup of it. can you check this PR fix your issue also? thanks.

ahpeterson commented 8 years ago

Yup, looks great. Thanks!