search

umegaya / lua-aws

pure-lua implementation of aws REST APIs
122 stars 35 forks source link

Updated code to work in windows and added reference to a bit library … #45

Closed aryajur closed 6 years ago

aryajur commented 6 years ago

…in the readme

umegaya commented 6 years ago

hi, sorry for delay, I took vacation :< thank you for your work! code seems ok, and test passes on osx.

but actually after adding your modification, lua-aws does not refer your library (aryajur/bit) at all. do you want to add the link for your library (aryajur/bit) to README as tips for lua 5.3 users (I think they lost standard bit library)?

if so, I will create new section "for lua 5.3 users" to separate compatibility issue, rather than adding unused library to the list of external libs.

aryajur commented 6 years ago

hi, yes the bit library is gone in 5.3 now bit operators are there. So yes making a 5.3 section is a good idea.

umegaya commented 6 years ago

ok, so I merge this and then modify README. thank you for response!

aryajur commented 6 years ago

Thank you!

On Sun, Jun 3, 2018, 11:10 PM iyatomi takehiro notifications@github.com wrote:

Merged #45 https://github.com/umegaya/lua-aws/pull/45.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/umegaya/lua-aws/pull/45#event-1660468726, or mute the thread https://github.com/notifications/unsubscribe-auth/AHEBHRJySz5ffpzPhpTowsX80oe0n3nBks5t5M9YgaJpZM4UH_xn .