umerijaz / TAXAassign

Pipeline to annotate sequences at different taxonomic levels using NCBI's taxonomy
20 stars 11 forks source link

Possible improvements for TAXAassign #1

Open frederic-mahe opened 11 years ago

frederic-mahe commented 11 years ago

Hi Umer,

here are some coding style or simplifications I suggest for the TAXAassign shell script. Several of the conditional loops you use could be replace with one-liners ( [[test]] || die). Some tests regarding the status of files (exists, is empty, etc), could also be simplified by using the new pattern substitutions in bash 4.0. But unfortunately, many computer still have bash 3.0 installed.

Best,