umgc / Summer2024

Summer 2024 Cohort for UMGC 670
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

441-team-c-feature-view-test---implement-layout-banner-and-buttons #443

Closed WhitneyMeulink closed 3 months ago

WhitneyMeulink commented 4 months ago

Thank you for your review. -Whitney Meulink view_tests

WhitneyMeulink commented 4 months ago

I moved it to the correct folder and added a column for results. view_tests2

StephenBuley commented 3 months ago

It looks like you've included a new flutter app in the folder view_test which should not exist. view_test.dart should be a view inside of Team-C/test_wizard/lib/views folder (maybe named view_test_view.dart for consistency, but either way is fine) and should not create a new MaterialApp - we want all of our screens to be from one App, which starts in Team-C/test_wizard/lib/main.dart. See Lana's branch lana_auth for how she did that, or you could follow what I did and add a button that goes from the home screen to that page in my branch starting with 402-team-c-task.... Either way, we shouldn't be returning a new MaterialApp, should ideally return a Scaffold.

GhauriM commented 3 months ago

Ok, I went ahead and made the changes Stephen requested. I also split the View_test file into the widget/viewtest.dart $ views/view_test_view.dart file to be consistent with the other features. Also, I removed the code that would create a whole new application. I ran the code and used the existing elevated button to launch the view_test page, but I did not push the changes in the main file for others to test. You can test the view_test page by changing the const line under MaterialPageRoute to const CreateViewTest().