umgc / Summer2024

Summer 2024 Cohort for UMGC 670
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

444-team-c-task---user-authentication-and-authorization---login--implement-layout-banner-and-buttons #445

Closed WhitneyMeulink closed 3 months ago

WhitneyMeulink commented 4 months ago

Thank you for your review. -Whitney Meulink login_dart_flutter

WhitneyMeulink commented 4 months ago

Moved to the correct folder.

StephenBuley commented 3 months ago

It looks like you've included a new flutter app in the folder login_page and modify_test which should not exist. login_page.dart and modify_test.dart should be views inside of Team-C/test_wizard/lib/views folder (maybe named <page_name>_view.dart for consistency, but either way is fine) and should not create a new MaterialApp - we want all of our screens to be from one App, which starts in Team-C/test_wizard/lib/main.dart. See Lana's branch lana_auth for how she did that, or you could follow what I did and add a button that goes from the home screen to that page in my branch starting with 402-team-c-task.... Either way, we shouldn't be returning a new MaterialApp, should ideally return a Scaffold.

StephenBuley commented 3 months ago

Ok team, same thing as the other one, I've made the changes requested above, edited a few other things to make use of reusable components, and added tests. Awesome job again @WhitneyMeulink getting this started, really cool search filter mechanic going on, and its always easier to edit something that already exists than it is to come up with it from the start, so really well done. @J-Gilberg , @hellohouseplant , @eshin2 , @Lanaismail , @GhauriM , in the interest of not reviewing a bunch of code I just wrote, please review when you can. Once we've got this we can update the dashboard component.

StephenBuley commented 3 months ago

Ok @hellohouseplant, changes made!