search

umgc / fall2022

SWEN 670 Fall 2022 cohort
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

Feature/combineEmail #626

Closed sHuber125 closed 2 years ago

sHuber125 commented 2 years ago

I would like to add these changes. Discussed with Mike earlier today. This combines all the email getting/login functions into a single class MailUtility. I didn't yet, but Class/File Client.dart can be deleted, and class/file mailPiece_email_fetcher can be deleted. I moved Client.dart feature into MailUtility (it just checks imapclient works with email/password for sign-in verification) and moved what I had in mailpiece_email_fetcher to mail_fetcher.

I also deleted any passing of email/username and password around app for the login function. The username / password can be obtained from Keychain in the MailUtility function prior to logging in, so no need to pass between functions.

I also renamed a couple classes that had "mail" in the name but were really only working with mailPieces and storage. I made it so only items with mail in the name are things that ask the MailUtility to get some emails and work on those emails.

shaneknows commented 2 years ago

Please fix merge conflicts

sHuber125 commented 2 years ago

Please fix merge conflicts

I updated. It could be because I had two or three PR at the same time there was a minor difference.